Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add try/catch of occasional crash when parsing json #243

Merged
merged 3 commits into from
Sep 26, 2017
Merged

fix: Add try/catch of occasional crash when parsing json #243

merged 3 commits into from
Sep 26, 2017

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Sep 26, 2017

Fixes #241

@HazAT HazAT self-assigned this Sep 26, 2017
@HazAT HazAT mentioned this pull request Sep 26, 2017
Closed
5 tasks
@HazAT HazAT requested a review from mitsuhiko September 26, 2017 10:56
mitsuhiko
mitsuhiko requested changes Sep 26, 2017
View reviewed changes
lib/NativeClient.js Outdated
try {
this._updateIgnoredModules(JSON.parse(moduleTable.payload));
} catch (e) {
console.log(e);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the console.log and add a comment about why we think this happens.

@HazAT HazAT merged commit 628cd70 into master Sep 26, 2017
@HazAT HazAT deleted the bugfix/json-parse branch September 26, 2017 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsuhiko mitsuhiko mitsuhiko requested changes

Assignees

@HazAT HazAT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HazAT @mitsuhiko