-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SyntaxError JSON Parse error: Expected '}' #241
Comments
I have seen this crash 3 times now. First 2 times before update to 0.23.2, and the last one when my iPhone was attached to Xcode 9 with CPU instrument on. Xcode logs up to app crashing:
Sentry in the mean time recorded this crash report, screenshots attached: I filed bug report with CodePush before with a prior crash, thinking that was the cause, but given the 14s gap here between the xhr CodePush download and the crash (gaps of minutes with my previous 2 crashes), I don't think CodePush's JSON is the cause. Since Sentry is made to debug crashes, it being the cause of app crashes would be somewhat ironic. 🙄 |
I also use Code Push. I'll double check the stack trace to see if anything shows up there. |
Hey, this bug should have been fixed with version > |
My mistake, I'm already on Committed fix looks good. |
@fungilation I've also added a try catch just in case. Still, it doesn't really make sense to me since I am checking for a valid JSON in Objective-C already before sending it over the bridge. I will merge this as soon the tests pass. |
Ya. Wish sentry records what the actual JSON is in my crash report? But obviously avoiding crashing apps is the priority and the try catch is needed, though fixing JSON at the source would be better. |
@fungilation Please upgrade to |
Thanks @HazAT. I will do the same and get back to you |
OS:
Platform:
Output of
node -v && npm -v && npm ls --prod --depth=0
Config:
I have following issue:
I'm receiving a bunch of errors in sentry that seem to point to
node_modules/react-native-sentry/lib/NativeClient.js
. Specifically, the error is:There's also a similar native error that references the module table, so they may be related:
Steps to reproduce:
Thanks for any assistance you are able to provide!
The text was updated successfully, but these errors were encountered: