- fix: removed circular dependencies #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexnaiman
requested review from
bruno-garcia,
HazAT and
jennmueng
as code owners
bruno-garcia
requested changes
Oct 26, 2020
bruno-garcia
added
the
Hacktoberfest-accepted
|
Label added :) |
|
Done! Thanks a lot for the label :) |
jennmueng
approved these changes
Oct 26, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
I checked for circular dependencies using
madge . --extensions ts,tsx -c --warningand fixed the issue (moved one interface to its own module)💡 Motivation and Context
This PR started as a fix for #479, but that issue isn't available anymore, but since I found other cyclic dependencies I removed those
💚 How did you test it?
I didn't introduce any major changes, just remade some imports. I just run all the existent tests
📝 Checklist
🔮 Next steps
I am looking forward to someone to merge this and maybe add the
hacktoberfest-acceptedlabel to it 😄