YellowBox: Require cycle: Sentry.js -> RavenClient.js -> Sentry.js #479

xufeipyxis · 2018-09-17T07:14:32Z

OS:

Windows
MacOS
Linux

Platform:

iOS
Android

Output of node -v && npm -v && npm ls --prod --depth=0

v8.11.4
6.4.1

I'm using react-native 0.57
On each run on a simulator, I have the following warning:

Require cycle: node_modules/react-native-sentry/lib/Sentry.js -> node_modules/react-native-sentry/lib/RavenClient.js -> node_modules/react-native-sentry/lib/Sentry.js

Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle.

It's annoying and I'd like to get rid of it.

The text was updated successfully, but these errors were encountered:

chpill · 2018-09-24T08:12:24Z

I'm also seeing this issue (I'm developping on Linux, and testing on an android device, react-native 0.57).

In addition to the require cycle you mention, I have another one:

Require cycle: node_modules/react-native/Libraries/Network/fetch.js -> node_modules/react-native/Libraries/vendor/core/whatwg-fetch.js -> node_modules/react-native/Libraries/Network/fetch.js

Interestingly, commenting require('react-native-sentry'); gets rid of both warnings.

burtek · 2018-10-24T19:44:46Z

Same here

damrem · 2019-01-23T15:29:56Z

Same issue. Some of the dep resolution I have:

[email protected]:
  version "0.57.7"

react-native-sentry@^0.36.0:
  version "0.36.0"
  dependencies:
    "@sentry/wizard" "^0.9.5"
    raven-js "^3.24.2"

"@sentry/wizard@^0.9.5":
  version "0.9.7"
  dependencies:
    "@sentry/cli" "^1.30.1"
    chalk "^2.3.1"
    glob "^7.1.2"
    inquirer "^5.1.0"
    lodash "^4.17.5"
    open "^0.0.5"
    r2 "^2.0.0"
    read-env "^1.1.1"
    xcode "^1.0.0"
    yargs "^11.0.0"

"@sentry/cli@^1.30.1":
  version "1.31.0"
  dependencies:
    https-proxy-agent "^2.1.1"
    node-fetch "^1.7.3"
    progress "2.0.0"
    proxy-from-env "^1.0.0"

raven-js@^3.24.2:
  version "3.25.1"

damrem · 2019-01-23T15:31:40Z

@chpill I opened this issue for this specific warning about fetch/whatwg-fetch in react-native: facebook/react-native#23130

msqar · 2019-02-25T23:01:39Z

Any idea on when this is going to be solved? :(

erenakbltt · 2019-04-26T15:30:32Z

Is this a critic problem? Same here on OS: MacOS Platform: IOS

moonrailgun · 2019-05-08T08:37:19Z

Same here and ignore it temporary

import { YellowBox } from 'react-native';
YellowBox.ignoreWarnings(['Require cycle:']); // Metro warning, Specific for Sentry

ricardovf · 2019-05-22T13:03:53Z

Same here running on iOS simulator with expo not ejected.

yarn list

YellowBox.ignoreWarnings(['Require cycle:']); fixed for now

burtek · 2019-05-22T13:07:07Z

@ricardovf please, put that list in <details></details>, scrolling through this issue hurts my finger... Sth like this:

<details>
<summary>yarn list</summary>

here list

</details>

davidimoore · 2019-06-20T18:20:01Z

I have followed these instructions explicitly and still see errors.
YellowBox.ignoreWarnings(['Require cycle:'])

ldco2016 · 2019-08-06T13:02:39Z

This was opened last year. Has it ever been resolved? I am getting the same warnings regarding sentry and other imports. It seems this require cycle issue may be causing my action creators to not initialize and return undefined. Please help.

MateusZitelli · 2019-08-08T17:03:39Z

We were having hard crashes because of this. import Sentry from 'react-native-sentry'; is returning undefined because of the circular dependency.

ldco2016 · 2019-08-08T17:05:37Z

After some debugging I realized the yellow warning was not the cause of the problem for my action creators, but the warning: Require cycle: node_modules/react-native-sentry/lib/Sentry.js -> node_modules/react-native-sentry/lib/RavenClient.js -> node_modules/react-native-sentry/lib/Sentry.js still exists. What needs to be done about this?

alexnaiman · 2020-10-24T17:01:10Z

Hello! Can I try to tackle this issue for the Hacktoberfest2020? If so, can you assign it to me?

jennmueng · 2020-10-24T17:05:28Z

@alexnaiman I'm not sure if this is an issue anymore with the new @sentry/react-native package. But if it is feel free to tackle it and just submit a PR.

alexnaiman · 2020-10-26T16:00:17Z

@jennmueng I checked for circular dependencies for @sentry/react-native and didn't found the mentioned cyclic dependency but I found this one:

src/js/backend.ts > src/js/transports/native.ts > src/js/wrapper.ts

So, I will submit PR with a fix for that if it is ok

jennmueng · 2020-10-26T16:28:28Z

Ok if this is no longer an issue let's close it.

KrisLau · 2022-02-11T18:19:47Z

@jennmueng Still getting require cycle warnings after installing

Require cycle: node_modules\react-native\Libraries\Network\fetch.js -> node_modules\whatwg-fetch\dist\fetch.umd.js -> node_modules\react-native\Libraries\Network\fetch.js

vconti-alfi · 2022-05-10T19:53:29Z

Yes this still happening when installing and using sentry:

Require cycle: node_modules/react-native/Libraries/Network/fetch.js -> node_modules/whatwg-fetch/dist/fetch.umd.js -> node_modules/react-native/Libraries/Network/fetch.js

marandaneto · 2022-05-11T09:29:03Z

#2080 is being tracked there, this is just a warning, though it does not harm the app.

chpill mentioned this issue Sep 24, 2018

[0.57.0] metroRequire errors: Require cycles are allowed, but can result in uninitialized values... facebook/react-native#20841

Closed

HazAT added the 🦔react-native-sentry label Jul 3, 2019

alexnaiman mentioned this issue Oct 26, 2020

- fix: removed circular dependencies #1144

Merged

8 tasks

jennmueng closed this as completed Oct 26, 2020

getsentry locked and limited conversation to collaborators May 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YellowBox: Require cycle: Sentry.js -> RavenClient.js -> Sentry.js #479

YellowBox: Require cycle: Sentry.js -> RavenClient.js -> Sentry.js #479

xufeipyxis commented Sep 17, 2018

chpill commented Sep 24, 2018 •

edited

Loading

burtek commented Oct 24, 2018

damrem commented Jan 23, 2019

damrem commented Jan 23, 2019

msqar commented Feb 25, 2019

erenakbltt commented Apr 26, 2019

moonrailgun commented May 8, 2019

ricardovf commented May 22, 2019 •

edited

Loading

burtek commented May 22, 2019 •

edited

Loading

davidimoore commented Jun 20, 2019

ldco2016 commented Aug 6, 2019

MateusZitelli commented Aug 8, 2019

ldco2016 commented Aug 8, 2019 •

edited

Loading

alexnaiman commented Oct 24, 2020

jennmueng commented Oct 24, 2020

alexnaiman commented Oct 26, 2020

jennmueng commented Oct 26, 2020

KrisLau commented Feb 11, 2022

vconti-alfi commented May 10, 2022 •

edited

Loading

marandaneto commented May 11, 2022

YellowBox: Require cycle: Sentry.js -> RavenClient.js -> Sentry.js #479

YellowBox: Require cycle: Sentry.js -> RavenClient.js -> Sentry.js #479

Comments

xufeipyxis commented Sep 17, 2018

chpill commented Sep 24, 2018 • edited Loading

burtek commented Oct 24, 2018

damrem commented Jan 23, 2019

damrem commented Jan 23, 2019

msqar commented Feb 25, 2019

erenakbltt commented Apr 26, 2019

moonrailgun commented May 8, 2019

ricardovf commented May 22, 2019 • edited Loading

burtek commented May 22, 2019 • edited Loading

davidimoore commented Jun 20, 2019

ldco2016 commented Aug 6, 2019

MateusZitelli commented Aug 8, 2019

ldco2016 commented Aug 8, 2019 • edited Loading

alexnaiman commented Oct 24, 2020

jennmueng commented Oct 24, 2020

alexnaiman commented Oct 26, 2020

jennmueng commented Oct 26, 2020

KrisLau commented Feb 11, 2022

vconti-alfi commented May 10, 2022 • edited Loading

marandaneto commented May 11, 2022

chpill commented Sep 24, 2018 •

edited

Loading

ricardovf commented May 22, 2019 •

edited

Loading

burtek commented May 22, 2019 •

edited

Loading

ldco2016 commented Aug 8, 2019 •

edited

Loading

vconti-alfi commented May 10, 2022 •

edited

Loading