@sentry/react-native - Hermes Support #649

HazAT · 2019-09-02T16:08:40Z

The current version as of 1.0.1 we have very basic support for Hermes bundles meaning we are able to get function names but not showing the correct line number / source code for the crash.

In order for us to support it fully, we need to do some changes on how we process minified sources and source maps on the server.

Keep an eye on this issue if you are interested in this topic.

1.0.1

The text was updated successfully, but these errors were encountered:

motiz88 · 2019-09-02T16:48:39Z

@HazAT: Please let me know if there's anything we can do on the React Native side to make this easier.

HazAT · 2019-09-03T07:25:53Z

@motiz88 Thanks again :)

Is there any way to output the minified js bundle that hermes uses internally?
The reason we need the minified code is that we try to get the function name from the crashed line and our symbolication code needs the minified bundle in order to do this correctly.

We initially thought the x_facebook_source is used for that but in our examples the value in there is always null.

motiz88 · 2019-09-03T07:34:27Z

x_facebook_sources is indeed designed for this (and is inherently more robust and complete than inspecting the bundled JS) so let's make it work. Can you share a complete example where it doesn't work for you?

HazAT · 2019-09-03T08:04:49Z

@motiz88 https://github.com/HazAT/testhermes

HazAT · 2019-09-05T11:44:34Z

@motiz88 Let me know if you need anything else.

motiz88 · 2019-09-09T14:29:27Z

@HazAT React Native 0.61 updates Metro (transitively via the RN CLI) to a version that populates x_facebook_sources. Could you test against that? We did not bump the Metro dependency in RN 0.60 because it had unrelated breaking changes.

HazAT · 2019-09-09T20:25:17Z

@motiz88 there is no 0.61.0 in the RN CLI yet, but will try again

HazAT · 2019-09-25T09:03:44Z

@motiz88 I can confirm with 0.61.0 x_facebook_sources is filled, let's see when we find time implementing this :)

tobi512 · 2019-10-17T13:12:14Z

Hi @HazAT, any timeline updates yet?
Would be great to see this as fast as possible since Hermes will drastically reduce our APK size and improve overall JS performance, two of our main pain points at the moment...

filipef101 · 2019-10-23T13:49:39Z

Will this mean react-native-v8 will be suported?

haikov · 2019-11-05T09:43:38Z

Hello @HazAT!

Is there anything the community can help with? I think it's kind of a blocking issue for a lot of RN developers as it's impossible to use Sentry with Hermes now.

Could you please let us know how we can help or is there any timeline on fixing it from Sentry's side?

HazAT · 2019-11-06T07:35:14Z

@gaykov Thank you for offering your help 🙏
Sadly adding this is not trivial, it requires mostly changes in sentry-cli which is written in rust.
Of course we gladly accept PRs but even I can’t tell you right now what exactly needs to be implemented to make this work.
What I can tell you; this is for sure on our roadmap but can’t give you any exact dates but I wouldn’t expect it in the upcoming weeks, realistic is Q1 2020.

mitsuhiko · 2019-11-06T08:21:13Z

So a quick description of the problem from me (who built a lot of the current version of the source map processing) for why Hermes is different:

Under normal circumstances we use the source map and minified file to look up a location in the source map, then reverse tokenize from that location in the minified source to the last function declaration that matches the function name in the backtrace. Then we use the source map to map this back into the original token at that location. This is described in greater detail here: https://blog.sentry.io/2019/07/16/building-sentry-source-maps-and-their-problems

With Hermes this approach no longer works because Hermes doesn't actually have source maps or minified source code. Instead if has something similar to source maps where the column offset is a bytecode instruction. Since there is no minified source, there is nothing to step back on. Additionally it requires changes to how the filenames are processed in the stack traces because there is again no actual minified file that shows up there.

If someone is interested in helping out on the implementation of this I can go into further detail on discord and explain the current ideas I have for dealing with it.

HazAT · 2020-02-05T11:38:59Z

Short update, @Swatinem did an amazing job, we have Hermes internally implemented and tested.
We need to bump dependencies and release everything, we will ship support for Hermes probably next week including using our new Android SDK, stay tuned.

#749

Kudos to @bruno-garcia @marandaneto

PR links:
getsentry/sentry-javascript#2406
#752
#754
getsentry/rust-sourcemap#22
getsentry/sentry-cli#646
getsentry/symbolic#187

HazAT · 2020-02-12T08:12:28Z

1.3.0 has been released with Hermes support!
There aren't any breaking changes, please check and double-check to delete all caches to make sure you have to latest version.

Thank you all for your patience!

desmondmc · 2020-02-14T08:12:32Z

@HazAT thanks for the updates! Maybe i'm doing something wrong but i just updated to 1.3.0 and i'm getting the following error when compiling: Do we need to have a minSdkVersion>=26 for this update to work?

> Transform artifact sentry-android-core.aar (io.sentry:sentry-android-core:2.0.0-rc04) with DexingNoClasspathTransform
AGPBI: {"kind":"error","text":"Invoke-customs are only supported starting with Android O (--min-api 26)","sources":[{}],"tool":"D8"}

> Transform artifact sentry-core.jar (io.sentry:sentry-core:2.0.0-rc04) with DexingNoClasspathTransform
AGPBI: {"kind":"error","text":"Default interface methods are only supported starting with Android N (--min-api 24): void io.sentry.core.IHub.addBreadcrumb(io.sentry.core.Breadcrumb)","sources":[{}],"tool":"D8"}

Works fine with "@sentry/react-native": "1.2.2"

Update:
Just needed to add the following to my app/build.gradle and now it works fine:

android {
    compileOptions {
        sourceCompatibility 1.8
        targetCompatibility 1.8
    }
    ...

mxmzb · 2020-02-17T20:27:10Z

Looks like I have issues with the dependency io.sentry:sentry-android:2.0.0-rc04 here after the update. I'll investigate more in-depth tomorrow, meanwhile here is what Android SDK says:

org.gradle.api.internal.tasks.TaskDependencyResolveException: Could not determine the dependencies of task ':app:preDebugBuild'.
	at org.gradle.api.internal.tasks.CachingTaskDependencyResolveContext.getDependencies(CachingTaskDependencyResolveContext.java:68)
	at org.gradle.execution.plan.TaskDependencyResolver.resolveDependenciesFor(TaskDependencyResolver.java:46)
	at org.gradle.execution.plan.LocalTaskNode.getDependencies(LocalTaskNode.java:106)
	at org.gradle.execution.plan.LocalTaskNode.resolveDependencies(LocalTaskNode.java:79)
	at org.gradle.execution.plan.DefaultExecutionPlan.addEntryTasks(DefaultExecutionPlan.java:175)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph.addEntryTasks(DefaultTaskExecutionGraph.java:139)
	at org.gradle.execution.TaskNameResolvingBuildConfigurationAction.configure(TaskNameResolvingBuildConfigurationAction.java:48)
	at org.gradle.execution.DefaultBuildConfigurationActionExecuter.configure(DefaultBuildConfigurationActionExecuter.java:57)
	at org.gradle.execution.DefaultBuildConfigurationActionExecuter.access$200(DefaultBuildConfigurationActionExecuter.java:26)
	at org.gradle.execution.DefaultBuildConfigurationActionExecuter$2.proceed(DefaultBuildConfigurationActionExecuter.java:63)
	at org.gradle.execution.DefaultTasksBuildExecutionAction.configure(DefaultTasksBuildExecutionAction.java:44)

... HUGE STACKTRACE GOING ON ...

org.gradle.api.internal.tasks.CachingTaskDependencyResolveContext.getDependencies(CachingTaskDependencyResolveContext.java:66)
	... 113 more
Caused by: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find io.sentry:sentry-android:2.0.0-rc04.
Searched in the following locations:
  - file:/Users/maxim/.m2/repository/io/sentry/sentry-android/2.0.0-rc04/sentry-android-2.0.0-rc04.pom
  - file:/Users/maxim/.m2/repository/io/sentry/sentry-android/2.0.0-rc04/sentry-android-2.0.0-rc04.jar
  - file:/Volumes/Projects/goodtendency/packages/goodtendency-app/node_modules/react-native/android/io/sentry/sentry-android/2.0.0-rc04/sentry-android-2.0.0-rc04.pom
  - file:/Volumes/Projects/goodtendency/packages/goodtendency-app/node_modules/react-native/android/io/sentry/sentry-android/2.0.0-rc04/sentry-android-2.0.0-rc04.jar
  - file:/Volumes/Projects/goodtendency/packages/goodtendency-app/node_modules/jsc-android/dist/io/sentry/sentry-android/2.0.0-rc04/sentry-android-2.0.0-rc04.pom
  - file:/Volumes/Projects/goodtendency/packages/goodtendency-app/node_modules/jsc-android/dist/io/sentry/sentry-android/2.0.0-rc04/sentry-android-2.0.0-rc04.jar
  - https://dl.google.com/dl/android/maven2/io/sentry/sentry-android/2.0.0-rc04/sentry-android-2.0.0-rc04.pom
  - https://dl.google.com/dl/android/maven2/io/sentry/sentry-android/2.0.0-rc04/sentry-android-2.0.0-rc04.jar
  - https://jcenter.bintray.com/io/sentry/sentry-android/2.0.0-rc04/sentry-android-2.0.0-rc04.pom
  - https://jcenter.bintray.com/io/sentry/sentry-android/2.0.0-rc04/sentry-android-2.0.0-rc04.jar
  - https://jitpack.io/io/sentry/sentry-android/2.0.0-rc04/sentry-android-2.0.0-rc04.pom
  - https://jitpack.io/io/sentry/sentry-android/2.0.0-rc04/sentry-android-2.0.0-rc04.jar
Required by:
    project :app > project :@sentry_react-native
    project :app > project :sentry_react-native

marandaneto · 2020-02-17T21:16:02Z

@mxmzb hey, we already have an issue for that, please look at #767 there's a workaround over there, thanks.

bruno-garcia · 2020-02-17T21:16:09Z

@mxmzb we're merged packages on jcenter and that seems to have unlisted our package.
We're working on a fix. Please follow this thread:
getsentry/sentry-android#270

marandaneto · 2020-02-18T10:54:10Z

it should be fixed :)

capJavert · 2020-02-22T09:54:02Z

I am still getting the same gibberish even after upgrading and uploading the new release with updated sourcemaps. Any tips if I am missing something? Is there a specific sentry server version needed to support this?

Things I did:

updated sentry
cleared android caches
updated versionCode
fresh build + upload to sentry

marandaneto · 2020-02-23T07:13:01Z

@capJavert hey, it might be related to #772

capJavert · 2020-02-23T09:13:05Z

Not really, My sourcemaps are generated and uploaded and look fine but for some reason when erroris logged in Sentry its still like the image above.

HazAT · 2020-02-24T13:28:25Z

@capJavert Can you please link to this issue on sentry.io?

capJavert · 2020-02-24T15:49:39Z

Nope, we use private instance of sentry inside the company. So the screenshot is from there. That is why I asked if some specific version of sentry server is required for this feature.

HazAT · 2020-02-24T15:51:12Z

I am pretty sure we didn't release an official image containing support for Hermes. You need to use the latest master or wait for the new release (I can't tell you when this will be).

mxmzb · 2020-02-26T18:28:22Z

I am pretty sure we didn't release an official image containing support for Hermes. You need to use the latest master or wait for the new release (I can't tell you when this will be).

But it says so in the release notes: https://github.com/getsentry/sentry-react-native/releases/tag/1.3.0

bruno-garcia · 2020-02-26T18:51:53Z

@HazAT was talking about Sentry. There are lots of changes on the backend to support this.
We've built it and deployed to sentry.io (we deploy multiple times a day to production). If you're running Sentry on-premise, you'll likely using our Docker files. Sentry now builds new images for each commit to master:

https://hub.docker.com/r/getsentry/sentry

You will need to update your on-prem installation to have the latest version of Sentry, and the latest SDK (seems you've got that covered).

mxmzb · 2020-02-26T19:02:43Z

@bruno-garcia Oh, I see, thanks for clarifying!

lorenzoangelini · 2020-12-22T15:27:33Z

Hi @HazAT , Into the next release of react-native also in ios hermes will avaiable, react-native-sentry is ready for this?

Swatinem · 2020-12-22T17:12:14Z

If the sourcemaps use a compatible format, its just a matter of tooling to make sure we use it for symbolication. Maybe file a new issue for this?

jennmueng · 2020-12-26T11:13:58Z

Created an Issue to investigate and ensure we support this: #1262

HazAT added the 🌟 @sentry/react-native label Sep 2, 2019

HazAT self-assigned this Sep 2, 2019

HazAT mentioned this issue Sep 2, 2019

@sentry/react-native - Tracking Issue - Feedback #612

Closed

7 tasks

HazAT changed the title ~~@sentry/hermes - 1.x.x - Hermes Support~~ @sentry/react-native - 1.x.x - Hermes Support Sep 2, 2019

HazAT changed the title ~~@sentry/react-native - 1.x.x - Hermes Support~~ @sentry/react-native - Hermes Support Sep 2, 2019

HazAT pinned this issue Sep 2, 2019

mitsuhiko mentioned this issue Nov 6, 2019

Implement hermes source maps getsentry/rust-sourcemap#21

Closed

artsy-peril bot mentioned this issue Nov 14, 2019

[WIP] Update sentry artsy/emission#1965

Closed

4 tasks

benlaverriere mentioned this issue Jan 2, 2020

Incompresible source code #699

Closed

7 tasks

HazAT mentioned this issue Feb 7, 2020

feat: Use new Android SDK #749

Merged

HazAT closed this as completed in #749 Feb 12, 2020

artsy-peril bot mentioned this issue Feb 19, 2020

WIP - Update sentry take 2 artsy/emission#2095

Closed

4 tasks

getsentry locked as resolved and limited conversation to collaborators Dec 22, 2020

bruno-garcia unpinned this issue Mar 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@sentry/react-native - Hermes Support #649

@sentry/react-native - Hermes Support #649

HazAT commented Sep 2, 2019 •

edited

Loading

motiz88 commented Sep 2, 2019 •

edited

Loading

HazAT commented Sep 3, 2019

motiz88 commented Sep 3, 2019

HazAT commented Sep 3, 2019

HazAT commented Sep 5, 2019 •

edited

Loading

motiz88 commented Sep 9, 2019

HazAT commented Sep 9, 2019

HazAT commented Sep 25, 2019

tobi512 commented Oct 17, 2019

filipef101 commented Oct 23, 2019

haikov commented Nov 5, 2019

HazAT commented Nov 6, 2019

mitsuhiko commented Nov 6, 2019

HazAT commented Feb 5, 2020 •

edited

Loading

HazAT commented Feb 12, 2020

desmondmc commented Feb 14, 2020 •

edited

Loading

mxmzb commented Feb 17, 2020 •

edited

Loading

marandaneto commented Feb 17, 2020

bruno-garcia commented Feb 17, 2020

marandaneto commented Feb 18, 2020

capJavert commented Feb 22, 2020 •

edited

Loading

marandaneto commented Feb 23, 2020

capJavert commented Feb 23, 2020 •

edited

Loading

HazAT commented Feb 24, 2020

capJavert commented Feb 24, 2020

HazAT commented Feb 24, 2020

mxmzb commented Feb 26, 2020

bruno-garcia commented Feb 26, 2020 •

edited

Loading

mxmzb commented Feb 26, 2020

lorenzoangelini commented Dec 22, 2020

Swatinem commented Dec 22, 2020

jennmueng commented Dec 26, 2020

@sentry/react-native - Hermes Support #649

@sentry/react-native - Hermes Support #649

Comments

HazAT commented Sep 2, 2019 • edited Loading

1.0.1

motiz88 commented Sep 2, 2019 • edited Loading

HazAT commented Sep 3, 2019

motiz88 commented Sep 3, 2019

HazAT commented Sep 3, 2019

HazAT commented Sep 5, 2019 • edited Loading

motiz88 commented Sep 9, 2019

HazAT commented Sep 9, 2019

HazAT commented Sep 25, 2019

tobi512 commented Oct 17, 2019

filipef101 commented Oct 23, 2019

haikov commented Nov 5, 2019

HazAT commented Nov 6, 2019

mitsuhiko commented Nov 6, 2019

HazAT commented Feb 5, 2020 • edited Loading

HazAT commented Feb 12, 2020

desmondmc commented Feb 14, 2020 • edited Loading

mxmzb commented Feb 17, 2020 • edited Loading

marandaneto commented Feb 17, 2020

bruno-garcia commented Feb 17, 2020

marandaneto commented Feb 18, 2020

capJavert commented Feb 22, 2020 • edited Loading

marandaneto commented Feb 23, 2020

capJavert commented Feb 23, 2020 • edited Loading

HazAT commented Feb 24, 2020

capJavert commented Feb 24, 2020

HazAT commented Feb 24, 2020

mxmzb commented Feb 26, 2020

bruno-garcia commented Feb 26, 2020 • edited Loading

mxmzb commented Feb 26, 2020

lorenzoangelini commented Dec 22, 2020

Swatinem commented Dec 22, 2020

jennmueng commented Dec 26, 2020

HazAT commented Sep 2, 2019 •

edited

Loading

motiz88 commented Sep 2, 2019 •

edited

Loading

HazAT commented Sep 5, 2019 •

edited

Loading

HazAT commented Feb 5, 2020 •

edited

Loading

desmondmc commented Feb 14, 2020 •

edited

Loading

mxmzb commented Feb 17, 2020 •

edited

Loading

capJavert commented Feb 22, 2020 •

edited

Loading

capJavert commented Feb 23, 2020 •

edited

Loading

bruno-garcia commented Feb 26, 2020 •

edited

Loading