feat: Implement workarounds for dealing with hermes bytecode #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
suggested changes
Feb 4, 2020
|
Confirmed, just tested it end to end, it works! |
jan-auer
reviewed
Feb 5, 2020
Swatinem
changed the title
jan-auer
approved these changes
Feb 6, 2020
kamilogorek
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering hermes bytecode, the file is cleared and flagged as minified source, that way it will get a correct sourcemap reference. Other than that, the update to
sourcemapwill make sure that the rewritten sourcemap will keep thex_facebook_sourcesscopes.