feat: Support Hermes (react-native) SourceMaps #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
force-pushed
the
hermes-sourcemaps
branch
from
cfc198e to
d459c64
Compare
|
Yeah. This is all a bit meh. I think one way we could go forward is instead of exposing the source map as the primary API to have view objects over them that provide the most common operations. We already effectively do something like this in symbolic where a source map often only makes sense when paired with the source view of the minified code. Might be worth looking into the firefox developer tools. They might have found better abstractions. |
mitsuhiko
requested changes
Feb 3, 2020
|
|
||
| let mut nums = parse_vlq_segment(mapping).ok()?.into_iter(); | ||
|
|
||
| column = (i64::from(column) + nums.next()?) as u32; |
There was a problem hiding this comment.
wonder if we want to deal with the overflow explicitly here.
There was a problem hiding this comment.
hm, the regular sourcemap code doesn’t either.
jan-auer
reviewed
Feb 4, 2020
mitsuhiko
approved these changes
Feb 4, 2020
mitsuhiko
requested changes
Feb 4, 2020
mitsuhiko
approved these changes
Feb 4, 2020
|
Confirmed, just tested it end to end, it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21
This exposes a new
SourceMapHermestype, which can look up the scope name via a bytecode offset.