fix(django): Fix psycopg3 reconnect error #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft since I am unsure how to properly test this change |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-psycopg
branch
from
7f1d61e to
8ff5063
Compare
|
Note to self: run tests with |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-psycopg
branch
from
8ff5063 to
c990999
Compare
szokeasaurusrex
changed the title
This was referenced Jun 6, 2024
|
Testing this change is not super-straightforward; I am still struggling to figure out how to make my test work. So that the lack of a test does not block the release of this bug fix, we will implement the test later. I have opened Issue #3139 to add a test, and have put my in-progress work in a draft PR linked on that issue |
sentrivana
approved these changes
Jun 11, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-psycopg
branch
from
c990999 to
6a9d152
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-3061