Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[psycopg3] Test that the SDK does not cause an error on DB reconnect #3139

Open
szokeasaurusrex opened this issue Jun 6, 2024 · 0 comments · May be fixed by #3138
Open

[psycopg3] Test that the SDK does not cause an error on DB reconnect #3139

szokeasaurusrex opened this issue Jun 6, 2024 · 0 comments · May be fixed by #3138
Labels
Component: Tests Dealing with tests Integration: Django Triaged Has been looked at recently during old issue triage

Comments

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Jun 6, 2024 •
edited
Loading

We should add a test for the changes implemented in #3111. We are not adding the test in that PR, since testing this change is somewhat difficult, and it makes little sense to allow the lack of a test block the release of the bug fix.

I have added my in-progress work on the unit test in #3138 – this draft should be used as a starting point
This was referenced Jun 6, 2024
Merged
Draft
@antonpirker antonpirker added this to the Django update milestone Jun 7, 2024
@antonpirker antonpirker removed this from the Django update milestone Jun 20, 2024
@szokeasaurusrex szokeasaurusrex added the Triaged Has been looked at recently during old issue triage label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Tests Dealing with tests Integration: Django Triaged Has been looked at recently during old issue triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Test for Psycopg3 fix getsentry/sentry-python
2 participants
@antonpirker @szokeasaurusrex