Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject tracing HTML meta tags in rendered HTML #2186

Closed
5 tasks done
antonpirker opened this issue Jun 22, 2023 · 5 comments
Closed
5 tasks done

Inject tracing HTML meta tags in rendered HTML #2186

antonpirker opened this issue Jun 22, 2023 · 5 comments
Assignees

Comments

@antonpirker
Copy link
Member

antonpirker commented Jun 22, 2023

Problem Statement

We have a function trace_propagation_meta() (https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/hub.py#L723) but it is never used anywhere.

Solution Brainstorm

This will make it WAAY easier for users to setup distributed tracing for use cases when the server is the head of trace and renders HTML and the JS in the frontend then picks up the trace.

@sl0thentr0py
Copy link
Member

duplicate
#1341

@sentrivana sentrivana removed their assignment Jun 23, 2023
@antonpirker antonpirker self-assigned this Jun 26, 2023
@antonpirker
Copy link
Member Author

Thanks for linking the other issue @sl0thentr0py
So we have this in Flask already. Nice.
I will probably remove trace_propagation_meta() with something new that uses the new top level functions and then make flask, fastaapi and django use this new function. Cool with you to remove trace_propagation_meta?

@sl0thentr0py
Copy link
Member

sl0thentr0py commented Jun 26, 2023

why remove? just change it internally if need be, this is on the hub so technically public api

@antonpirker
Copy link
Member Author

Was just thinking this, keeping it and just change the internals.

antonpirker added a commit that referenced this issue Jun 28, 2023
Use new top level api in trace_propagation_meta and also move the functions into the Hub, so they can be used in the Hub. (following the pattern of other top level API)

Refs #2186
@antonpirker
Copy link
Member Author

This is done, closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants