Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta tag helper for trace propagation to Django. #1341

Closed
AbhiPrasad opened this issue Feb 14, 2022 · 5 comments
Closed

Add meta tag helper for trace propagation to Django. #1341

AbhiPrasad opened this issue Feb 14, 2022 · 5 comments

Comments

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Feb 14, 2022

Add sentry_trace() template helper for Django

We should make it easy to add sentry trace meta header OOB in Django. See feedback: #1171

Similar to work done in #1336

EDIT(neel): just start injecting the meta tags automatically

@antonpirker antonpirker added this to the Support for Django 4 milestone Jun 1, 2022
@sl0thentr0py sl0thentr0py self-assigned this Sep 27, 2022
@antonpirker antonpirker changed the title Add sentry_trace() template helper for Django Add meta tag helper for trace propagation to Django templates. Oct 19, 2022
@antonpirker antonpirker changed the title Add meta tag helper for trace propagation to Django templates. Add meta tag helper for trace propagation to Django. Oct 19, 2022
@pickfire
Copy link

pickfire commented May 8, 2023

There is now trace_propagation_meta to help for this #1171, probably need to add a middleware for sentry.

@antonpirker
Copy link
Member

Yes, to solve this issue we just need to inject the result of trace_propagation_meta() into Django responses.

Maybe this can be done in here: https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/integrations/django/views.py#L32-L38

Want to give it a go @pickfire ?

@pickfire
Copy link

pickfire commented May 8, 2023

Sorry, I am not interested in working on this myself, given that it's already working for us using the long way.

@antonpirker
Copy link
Member

Hey @pickfire

It's fine if you do not want to work on it.
Internernally we will work on something in the next couple of weeks, where we will this feature here, so I guess it will be solved soonish.

@sentrivana
Copy link
Contributor

Closing in favor of #2186

@sentrivana sentrivana closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants