Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix): Check the error data before spreading. #9664

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

onurtemizkan
Copy link
Collaborator

Closes: #9279

Note: The original case mentioned in the issue (capturing 404 responses) is addressed by #9655.

@onurtemizkan onurtemizkan force-pushed the onur/remix-check-before-spreading branch from 594713e to 803996d Compare November 27, 2023 15:30
@onurtemizkan onurtemizkan force-pushed the onur/remix-check-before-spreading branch from 803996d to 393737a Compare November 27, 2023 15:38
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.85 KB (-0.25% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 59.45 KB (+5.78% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.11 KB (-0.27% 🔽)
@sentry/browser - Webpack (gzipped) 21.37 KB (-0.14% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.7 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.52 KB (+0.19% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.6 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 197.4 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 89.28 KB (+0.15% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 64.24 KB (+0.19% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 32.17 KB (+0.16% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.24 KB (-0.29% 🔽)
@sentry/react - Webpack (gzipped) 21.42 KB (-0.15% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.95 KB (-0.26% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 48.2 KB (-0.24% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 16.19 KB (-0.02% 🔽)

@AbhiPrasad AbhiPrasad merged commit 7249cf9 into develop Nov 27, 2023
56 checks passed
@AbhiPrasad AbhiPrasad deleted the onur/remix-check-before-spreading branch November 27, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Risk of wrongly spreading a string in captureRemixErrorBoundaryError
2 participants