fix(remix): Don't capture error responses that are not 5xx on Remix v2. #9655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
force-pushed
the
onur/remix-v2-errorboundary-404
branch
from
0ee85ea to
6f2d67e
Compare
onurtemizkan
changed the title
onurtemizkan
force-pushed
the
onur/remix-v2-errorboundary-404
branch
from
6f2d67e to
219062f
Compare
AbhiPrasad
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #9489
Manually tested. Could not figure a way to e2e or integration test this, with our current test setup.
Note: Server-side transactions are still reported regardless they are 404 or not.