Raven.uninstall also restores builtin methods #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -613,7 +620,7 @@ Raven.prototype = { | |||
| if (prop in xhr && Object.prototype.toString.call(xhr[prop]) === '[object Function]') { | |||
| fill(xhr, prop, function (orig) { | |||
| return self.wrap(orig); | |||
| }); | |||
| }, true); | |||
There was a problem hiding this comment.
We need to also restore the XMLHttpRequest.prototype.open that was replaced.
benvinegar
force-pushed
the
uninstall-builtins
branch
from
dd94eb5 to
944323c
Compare
benvinegar
force-pushed
the
uninstall-builtins
branch
from
944323c to
276782f
Compare
benvinegar
added a commit
that referenced
this pull request
Jan 6, 2016
Raven.uninstall also restores builtin methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.