-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raven.uninstall() does not restore setTimeout/setInterval #228
Comments
This is somewhat related to #105 and might be why @bobbyrenwick was still ending up with raven handling. |
welp, this is going to be complicated since plugins are pretty sketchy right now and plugins don't have a concept of uninstalling. |
See #282 |
@benvinegar thoughts on this? We don't have any support yet for removing our polyfills. |
Yeah, I'm going to prioritize this. |
Fixed in #449 |
Wonderful thank you! |
1 task
billyvg
added a commit
that referenced
this issue
Dec 12, 2024
Includes the following fixes: - fix: remote CSS does not get rebuilt properly ([#226](getsentry/rrweb#226)) - fix(snapshot): Set <link> attributes to null for remote CSS ([#227](getsentry/rrweb#227)) - fix(snapshot): Change to ignore all link[rel="modulepreload"] ([#228](getsentry/rrweb#228))
billyvg
added a commit
that referenced
this issue
Dec 12, 2024
Includes the following fixes: - fix: remote CSS does not get rebuilt properly ([#226](getsentry/rrweb#226)) - fix(snapshot): Set <link> attributes to null for remote CSS ([#227](getsentry/rrweb#227)) - fix(snapshot): Change to ignore all link[rel="modulepreload"] ([#228](getsentry/rrweb#228))
billyvg
added a commit
that referenced
this issue
Dec 12, 2024
Includes the following fixes: - fix: remote CSS does not get rebuilt properly ([#226](getsentry/rrweb#226)) - fix(snapshot): Set <link> attributes to null for remote CSS ([#227](getsentry/rrweb#227)) - fix(snapshot): Change to ignore all link[rel="modulepreload"] ([#228](getsentry/rrweb#228))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using Raven 1.1.15:
Raven.uninstall()
setTimeout(function () { throw('oh no'); }, 0);
Expected: Native browser error handling
Actual:
Error: Raven has not been configured
thrown in Raven-wrapped functionLooks like the functions
setInterval
andsetTimeout
are overridden byextendToAsynchronousCallbacks
but never properly restored.The text was updated successfully, but these errors were encountered: