Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raven.uninstall() does not restore setTimeout/setInterval #228

Closed
hughes opened this issue Jul 16, 2014 · 7 comments
Closed

Raven.uninstall() does not restore setTimeout/setInterval #228

hughes opened this issue Jul 16, 2014 · 7 comments
Assignees

Comments

@hughes
Copy link

hughes commented Jul 16, 2014

Using Raven 1.1.15:

  1. Load Raven
  2. Raven.uninstall()
  3. setTimeout(function () { throw('oh no'); }, 0);

Expected: Native browser error handling
Actual: Error: Raven has not been configured thrown in Raven-wrapped function

Looks like the functions setInterval and setTimeout are overridden by extendToAsynchronousCallbacks but never properly restored.

@hughes
Copy link
Author

hughes commented Jul 16, 2014

This is somewhat related to #105 and might be why @bobbyrenwick was still ending up with raven handling.

@mattrobenolt
Copy link
Contributor

welp, this is going to be complicated since plugins are pretty sketchy right now and plugins don't have a concept of uninstalling.

@mattrobenolt
Copy link
Contributor

See #282

@mattrobenolt
Copy link
Contributor

@benvinegar thoughts on this? We don't have any support yet for removing our polyfills.

@benvinegar
Copy link
Contributor

Yeah, I'm going to prioritize this.

@benvinegar benvinegar self-assigned this Dec 31, 2015
@benvinegar
Copy link
Contributor

Fixed in #449

@hughes
Copy link
Author

hughes commented Jan 19, 2016

Wonderful thank you!

billyvg added a commit that referenced this issue Dec 12, 2024
Includes the following fixes:

- fix: remote CSS does not get rebuilt properly ([#226](getsentry/rrweb#226))
- fix(snapshot): Set <link> attributes to null for remote CSS ([#227](getsentry/rrweb#227))
- fix(snapshot): Change to ignore all link[rel="modulepreload"] ([#228](getsentry/rrweb#228))
billyvg added a commit that referenced this issue Dec 12, 2024
Includes the following fixes:

- fix: remote CSS does not get rebuilt properly ([#226](getsentry/rrweb#226))
- fix(snapshot): Set <link> attributes to null for remote CSS ([#227](getsentry/rrweb#227))
- fix(snapshot): Change to ignore all link[rel="modulepreload"] ([#228](getsentry/rrweb#228))
billyvg added a commit that referenced this issue Dec 12, 2024
Includes the following fixes:

- fix: remote CSS does not get rebuilt properly
([#226](getsentry/rrweb#226))
- fix(snapshot): Set <link> attributes to null for remote CSS
([#227](getsentry/rrweb#227))
- fix(snapshot): Change to ignore all link[rel="modulepreload"]
([#228](getsentry/rrweb#228))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants