-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ember: Upgrade Embroider dependencies #4128
Ember: Upgrade Embroider dependencies #4128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexlafroscia thanks for updating the other deps as well! Yeah, --ignore-engines
should be fine for the interim, all the tests pass and the addon functions, I believe it should be okay since we're using a lower version of node and not a higher one.
Mind fixing the Will merge after that. Thanks! |
1b47eb9
to
9c95cfa
Compare
Rebased to fix the conflicts 👍 thanks for the reminder @AbhiPrasad! |
@AbhiPrasad As of the latest commit here, there are |
@alexlafroscia Don't worry about that, we can take care of it afterwards You'll have to rebase again because we just cut a release, sorry for the trouble. |
9c95cfa
to
d7a44cf
Compare
No problem! Rebased again 👍 Embroider also released a newer version yesterday, so I upgraded to that while rebasing |
For Thoughts @k-fish? |
Two old versions were brought in by @sentry/ember - `0.4.x` was brought in by the very specific, old version of ember-auto-import that the package depends on. It is only able to depend on `1.6.x` releases, which date back to June of 2020 - `0.37.0` was depended on specifically, but the latest is `0.47.1`. Because these are pre-major releases, they will not naturally fluctuate to a newer version This PR updates both of these dependencies to the latest versions possible without making a breaking change.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint
) & (yarn test
).I've been trying to hunt down old versions of Embroider in my application's dependencies and get them upgraded to the last versions possible.
Two old versions were brought in by
@sentry/ember
0.4.x
was brought in by the very specific, old version ofember-auto-import
that the package depends on. It is only able to depend on1.6.x
releases, which date back to June of 20200.37.0
was depended on specifically, but the latest is0.47.1
. Because these are pre-major releases, they will not naturally fluctuate to a newer versionThis PR updates both of these dependencies to the latest versions possible without making a breaking change.
ember-auto-import
version 2 is available, but upgrading to depend on that would be a breaking change to@sentry/ember
as it requires that the host app also depends onember-auto-import
version 2. I don't know how you all schedule breaking changes given that all of your packages use the same version numbers, so I decided not to upgrade all the way to that.