Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(ember): Bump embroider macro version #4108

Closed
wants to merge 1 commit into from

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Nov 1, 2021

Summary

Bump the embroider macros version to the latest in case there are Ember addon dependency issues with the older version.

Bump the embroider macros version to the latest in case there are Ember addon dependency issues with the older version.
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good looking yarn.lock changes

@AbhiPrasad
Copy link
Member

Ah it seems you'll have to bump the min node version? Will that cause problems?

@k-fish
Copy link
Member Author

k-fish commented Nov 2, 2021

@AbhiPrasad it might, so I'll maybe use the ignore-engines flag and see if I can get around it for now.

@k-fish
Copy link
Member Author

k-fish commented Nov 8, 2021

Closing in lieu of the other PR.

@k-fish k-fish closed this Nov 8, 2021
@AbhiPrasad AbhiPrasad deleted the ref/ember-update-embroider-macros branch May 30, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants