Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add runtime classes for FileIOStream instrumentation #1826

Merged
merged 32 commits into from
Dec 13, 2021
Merged

feat: Add runtime classes for FileIOStream instrumentation #1826

merged 32 commits into from
Dec 13, 2021

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Dec 3, 2021 •
edited
Loading

📜 Description

  • Added SentryFileInputStream implementation for FileInputStream instrumentation
  • Added SentryFileOutputStream implementation for FileOutputStream instrumentation

💡 Motivation and Context

This is a supporting PR with runtime classes for File I/O instrumentation see getsentry/sentry-android-gradle-plugin#239

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

  • Will follow up with another PR for FileReader/Writer
  • Will update docs to show how to manually use it

@romtsn romtsn marked this pull request as ready for review December 9, 2021 13:39
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a3b6103

@romtsn romtsn merged commit 4c1cf85 into main Dec 13, 2021
@romtsn romtsn deleted the feat/file-io-stream-instr branch December 13, 2021 19:02
maciejwalkowiak pushed a commit that referenced this pull request Jan 5, 2022
@romtsn @maciejwalkowiak
feat: Add runtime classes for FileIOStream instrumentation (#1826)
72c2195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia left review comments

@untitaker untitaker untitaker left review comments

@marandaneto marandaneto marandaneto approved these changes

@maciejwalkowiak maciejwalkowiak Awaiting requested review from maciejwalkowiak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@romtsn @codecov-commenter @untitaker @bruno-garcia @marandaneto