-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: FileInputStream/FileOutputStream instrumentation #239
Conversation
|
override fun isInstrumentable(data: ClassContext): Boolean { | ||
return when { | ||
data.currentClassData.className.startsWith("io.sentry") | ||
&& !data.currentClassData.className.startsWith("io.sentry.android.roomsample") -> false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just for the sample to work, probably shouldn't be in the production code.. maybe worth introducing ignore list config in the gradle plugin, where users can specify packagenames to ignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, but I'd rather take it as feature request, not really part of this PR.
we could rename the sample package if necessary to avoid this.
on Java, we special case these packages btw https://github.com/getsentry/sentry-java/blob/main/sentry/src/main/java/io/sentry/SentryStackTraceFactory.java#L41-L46
because of our samples and mobile app.
why |
targeting integration branch for now |
examples/android-room/src/main/java/io/sentry/android/roomsample/ui/LyricsActivity.kt
Show resolved
Hide resolved
examples/android-room/src/main/java/io/sentry/android/roomsample/ui/MainActivity.kt
Outdated
Show resolved
Hide resolved
...ld/src/main/kotlin/io/sentry/android/gradle/instrumentation/remap/RemappingInstrumentable.kt
Outdated
Show resolved
Hide resolved
@marandaneto PTAL. We've changed approach so this
Turns into this
|
...src/test/kotlin/io/sentry/android/gradle/instrumentation/wrap/visitor/WrappingVisitorTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#skip-changelog
📜 Description
💡 Motivation and Context
💚 How did you test it?
Manually for now - automated tests will follow in future PRs
📝 Checklist
🔮 Next steps
The PR is targeting integration branch for now, the next steps are: