Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add secondary constructor to SentryInstrumentation. #1804

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Feat: Add secondary constructor to SentryInstrumentation. #1804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0bf0d4
Feat: Add secondary constructor to `SentryInstrumentation`.
maciejwalkowiak Nov 12, 2021
0b7b0b9
Changelog.
maciejwalkowiak Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

* Feat: Refactor OkHttp and Apollo to Kotlin functional interfaces (#1797)
* Feat: Add secondary constructor to SentryInstrumentation (#1804)

## 5.4.0

Expand Down
1 change: 1 addition & 0 deletions sentry-graphql/api/sentry-graphql.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ public final class io/sentry/graphql/SentryInstrumentation : graphql/execution/i
public fun <init> ()V
public fun <init> (Lio/sentry/IHub;)V
public fun <init> (Lio/sentry/IHub;Lio/sentry/graphql/SentryInstrumentation$BeforeSpanCallback;)V
public fun <init> (Lio/sentry/graphql/SentryInstrumentation$BeforeSpanCallback;)V
public fun beginExecution (Lgraphql/execution/instrumentation/parameters/InstrumentationExecutionParameters;)Lgraphql/execution/instrumentation/InstrumentationContext;
public fun createState ()Lgraphql/execution/instrumentation/InstrumentationState;
public fun instrumentDataFetcher (Lgraphql/schema/DataFetcher;Lgraphql/execution/instrumentation/parameters/InstrumentationFieldFetchParameters;)Lgraphql/schema/DataFetcher;
Expand Down
4 changes: 4 additions & 0 deletions sentry-graphql/src/main/java/io/sentry/graphql/SentryInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ public SentryInstrumentation(
this.beforeSpan = beforeSpan;
}

public SentryInstrumentation(final @Nullable BeforeSpanCallback beforeSpan) {
this(HubAdapter.getInstance(), beforeSpan);
}

public SentryInstrumentation(final @NotNull IHub hub) {
this(hub, null);
}
Expand Down