Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add secondary constructor to SentryInstrumentation. #1804

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Feat: Add secondary constructor to SentryInstrumentation.

💡 Motivation and Context

It wasn't possible to pass BeforeSpanCallback without passing the Hub.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review November 12, 2021 10:08
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #1804 (0b7b0b9) into main (5ba7d38) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1804      +/-   ##
============================================
- Coverage     75.74%   75.72%   -0.02%     
  Complexity     2194     2194              
============================================
  Files           218      218              
  Lines          7804     7806       +2     
  Branches        828      828              
============================================
  Hits           5911     5911              
- Misses         1491     1493       +2     
  Partials        402      402              
Impacted Files Coverage Δ
.../java/io/sentry/graphql/SentryInstrumentation.java 71.18% <0.00%> (-2.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ba7d38...0b7b0b9. Read the comment docs.

@marandaneto marandaneto merged commit 61ea653 into main Nov 12, 2021
@marandaneto marandaneto deleted the graphql-instrumentation-constructor branch November 12, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants