Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secondary constructor taking IHub to SentryOkHttpInterceptor. #1657

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Add secondary constructor taking IHub to SentryOkHttpInterceptor. #1657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad2d108
Add secondary constructor taking `IHub` to `SentryOkHttpInterceptor`.
maciejwalkowiak Aug 18, 2021
6f9b7d2
Polish.
maciejwalkowiak Aug 18, 2021
b3341f5
Merge branch 'main' into okinterceptor-constructor
maciejwalkowiak Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Unreleased

* Feat: Add secondary constructor taking IHub to SentryOkHttpInterceptor (#1657)
* Feat: Merge external map properties (#1656)

## 5.1.0
Expand Down
1 change: 1 addition & 0 deletions sentry-android-okhttp/api/sentry-android-okhttp.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ public final class io/sentry/android/okhttp/BuildConfig {

public final class io/sentry/android/okhttp/SentryOkHttpInterceptor : okhttp3/Interceptor {
public fun <init> ()V
public fun <init> (Lio/sentry/IHub;)V
public fun <init> (Lio/sentry/IHub;Lio/sentry/android/okhttp/SentryOkHttpInterceptor$BeforeSpanCallback;)V
public synthetic fun <init> (Lio/sentry/IHub;Lio/sentry/android/okhttp/SentryOkHttpInterceptor$BeforeSpanCallback;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public fun <init> (Lio/sentry/android/okhttp/SentryOkHttpInterceptor$BeforeSpanCallback;)V
Expand Down
1 change: 1 addition & 0 deletions sentry-android-okhttp/src/main/java/io/sentry/android/okhttp/SentryOkHttpInterceptor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ class SentryOkHttpInterceptor(
private val beforeSpan: BeforeSpanCallback? = null
) : Interceptor {

constructor(hub: IHub) : this(hub, null)
constructor(beforeSpan: BeforeSpanCallback) : this(HubAdapter.getInstance(), beforeSpan)

override fun intercept(chain: Interceptor.Chain): Response {
Expand Down