Add secondary constructor taking IHub to SentryOkHttpInterceptor.
#1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the sake of improving Java compatiblity when users want to set only `IHub` and skip `BeforeSendCallback`. Fixes #1526
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
marandaneto
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
@maciejwalkowiak make api and changelog, other than that, LGTM
Codecov Report
@@ Coverage Diff @@
## main #1657 +/- ##
=========================================
Coverage 75.74% 75.74%
Complexity 2016 2016
=========================================
Files 206 206
Lines 7037 7037
Branches 699 699
=========================================
Hits 5330 5330
Misses 1369 1369
Partials 338 338 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Add secondary constructor taking
IHubtoSentryOkHttpInterceptor.💡 Motivation and Context
For the sake of improving Java compatiblity when users want to set only
IHuband skipBeforeSendCallback.Fixes #1526
💚 How did you test it?
📝 Checklist