-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Ser/Deser of the UserFeedback from cached envelope #1611
Conversation
// special case the String 'user_report since the enum is called UserFeedback | ||
// instead of UserReport, this is gonna be fixed when we move away from reflection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## main #1611 +/- ##
============================================
+ Coverage 75.90% 75.93% +0.02%
- Complexity 2000 2003 +3
============================================
Files 202 202
Lines 6935 6939 +4
Branches 688 690 +2
============================================
+ Hits 5264 5269 +5
Misses 1334 1334
+ Partials 337 336 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just minor naming suggestions.
📜 Description
Fix: Ser/Deser of the UserFeedback from cached envelope #1611
💡 Motivation and Context
Fix getsentry/sentry-dart#534
💚 How did you test it?
📝 Checklist
🔮 Next steps