Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ser/Deser of the UserFeedback from cached envelope #1611

Merged
merged 3 commits into from
Jul 20, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jul 20, 2021

📜 Description

Fix: Ser/Deser of the UserFeedback from cached envelope #1611

💡 Motivation and Context

Fix getsentry/sentry-dart#534

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@marandaneto
Copy link
Contributor Author

@ueman

CHANGELOG.md Outdated Show resolved Hide resolved
Comment on lines +76 to +77
// special case the String 'user_report since the enum is called UserFeedback
// instead of UserReport, this is gonna be fixed when we move away from reflection.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

Codecov Report

Merging #1611 (c176ec2) into main (ab5a278) will increase coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1611      +/-   ##
============================================
+ Coverage     75.90%   75.93%   +0.02%     
- Complexity     2000     2003       +3     
============================================
  Files           202      202              
  Lines          6935     6939       +4     
  Branches        688      690       +2     
============================================
+ Hits           5264     5269       +5     
  Misses         1334     1334              
+ Partials        337      336       -1     
Impacted Files Coverage Δ
...ava/io/sentry/SentryEnvelopeItemHeaderAdapter.java 74.07% <83.33%> (+0.07%) ⬆️
...y/src/main/java/io/sentry/protocol/SdkVersion.java 74.28% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5a278...c176ec2. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor naming suggestions.

@marandaneto marandaneto merged commit 4d1fa0d into main Jul 20, 2021
@marandaneto marandaneto deleted the fix/userfeedback_ser branch July 20, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error "invalid event envelope" when send user feedback.
3 participants