Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test case was missing an
assert
and was passing without testing what it was supposed to. After addingassert
it doesn't pass because in:async
or:none
modesmaybe_log_result
'sresult
isThat makes me think
{:error, {:request_failure, last_error}}
is unreachable under default config and client errors would never be logged. Maybe instead of logging on task / result, logging for invalid request could happen from within the task?