Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a void test #516

Closed
wants to merge 1 commit into from
Closed

fix a void test #516

wants to merge 1 commit into from

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Jul 27, 2022

This test case was missing an assert and was passing without testing what it was supposed to. After adding assert it doesn't pass because in :async or :none modes maybe_log_result's result is

{:ok,
 %Task{
   owner: #PID<0.393.0>,
   pid: #PID<0.406.0>,
   ref: #Reference<0.1323136707.3469803524.187842>
 }}

That makes me think {:error, {:request_failure, last_error}} is unreachable under default config and client errors would never be logged. Maybe instead of logging on task / result, logging for invalid request could happen from within the task?

@ruslandoga ruslandoga changed the title show a void test fix a void test Jul 27, 2022
@ruslandoga
Copy link
Contributor Author

ruslandoga commented Jul 27, 2022

closing in favor of #517

@ruslandoga ruslandoga closed this Jul 27, 2022
@ruslandoga ruslandoga deleted the void-test branch July 27, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant