-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap HTTP requests in try/catch #515
Conversation
Hey @mitchellhenke. Sorry to bother you but we'd like to move this along if you have some time to look at it. The issue with infinite error loops #514 is forcing us to run a fork of this library in prod for https://plausible.io We know from first-hand experience how difficult it is to maintain OS libraries on the side. We're committed to open source work and want to help out the whole ecosystem with the resources that we have. @ruslandoga has recently started working with us as a dedicated Open Source developer to help improve the ecosystem we depend on. The work we do in OSS is with dedicated funding from 5% donation budget which we launched last year. I'm not sure how this project is run or managed. If you need help, we'd be happy to be discuss onboarding @ruslandoga as a maintainer to lighten your load going forward. Not trying to be pushy, just offering some free help. Thanks for all of your work on this so far ❤️ |
@ruslandoga I'm breathing new life into this repo, would you still like to see this merged? |
@sl0thentr0py Sure! |
Done. I'll go over this PR |
Sorry for taking so long to get back to it. I've cleaned up the PR to only fix the original issue. It should make it easier to review. I'll open another PR for direct logging from the client once this one is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👏
closes #514