-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Manually capturing user feedback #559
feat: Manually capturing user feedback #559
Conversation
🤔 Should I edit the changelog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing again Lucas! I left a few comments.
Yes please |
…lock from sentryclient, renamed sentryuserfeedback) and added more unit tests.
Codecov Report
@@ Coverage Diff @@
## main #559 +/- ##
==========================================
- Coverage 85.06% 84.85% -0.22%
==========================================
Files 142 143 +1
Lines 3462 3513 +51
Branches 775 784 +9
==========================================
+ Hits 2945 2981 +36
- Misses 310 323 +13
- Partials 207 209 +2
Continue to review full report at Codecov.
|
weird, the test worked fine on my computer. public static void CaptureUserFeedback(SentryId eventId, string email, string comments, string? name = null) EDIT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Left a couple notes.
Thanks!
...s/Sentry.Samples.Console.ManualUserFeedback/Sentry.Samples.Console.ManualUserFeedback.csproj
Outdated
Show resolved
Hide resolved
… and minor requested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful stuff!! Thanks a lot @lucas-zimerman
Based on getsentry/sentry-cocoa#805
This PR implements the CaptureUserFeedback so users can associate user feedback to an event.
Fixes #153