feat: Manually capturing user feedback #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SentrySDK now provides a method captureUserFeedback to associate user feedback to an event.
philipphofmann
changed the title
Closed
philipphofmann
commented
Oct 20, 2020
| /** | ||
| * Adds additional information about what happened to an event. | ||
| */ | ||
| NS_SWIFT_NAME(UserFeedack) |
There was a problem hiding this comment.
m: Because we were talking about this at the standup, should we call this now also SentryUserFeedback in Swift? @bruno-garcia, @marandaneto and @jennmueng
There was a problem hiding this comment.
Given that UserFeedback is a more specific name, I have no strong feelings here.
I rather default to SentryName when the name is super generic like Client or Event.
bruno-garcia
approved these changes
Oct 20, 2020
| /** | ||
| * Adds additional information about what happened to an event. | ||
| */ | ||
| NS_SWIFT_NAME(UserFeedack) |
There was a problem hiding this comment.
Given that UserFeedback is a more specific name, I have no strong feelings here.
I rather default to SentryName when the name is super generic like Client or Event.
6 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
The SentrySDK now provides a method captureUserFeedback to associate user feedback to an event. A callback to send user feedback after a hard crash is going to be delivered in another PR.
💡 Motivation and Context
We want to bring this awesome feature to our customers.
💚 How did you test it?
Unit tests and with a simulator.
📝 Checklist
🔮 Next steps