Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document HTTP Client Errors (enableCaptureFailedRequests) #6987

Merged

Conversation

jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented May 18, 2023

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Issue #6984 Document HTTP Client Errors (enableCaptureFailedRequests).

These are very similar to the Java and Apple iOS docs, with minor variations.

Extra resources

@jamescrosswell jamescrosswell requested a review from a team as a code owner May 18, 2023 21:46
@vercel
Copy link

vercel bot commented May 18, 2023

@jamescrosswell is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented May 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 6:00pm

Copy link
Contributor

@mattjohnsonpint mattjohnsonpint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A few notes left inline. Also, we need to update the Basic Options page to ensure these options are listed. I believe there's already some stubs for them for other platforms. Would be good to link from there to this page also. Thanks!

Copy link
Contributor

@mattjohnsonpint mattjohnsonpint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update per comments. Thanks.

@mattjohnsonpint mattjohnsonpint linked an issue May 22, 2023 that may be closed by this pull request
@mattjohnsonpint mattjohnsonpint merged commit 3ac0e0e into getsentry:master May 22, 2023
@jamescrosswell jamescrosswell deleted the dotnet-http-client-errors branch May 22, 2023 21:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document HTTP Client Errors (enableCaptureFailedRequests)
2 participants