Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document HTTP Client Errors (enableCaptureFailedRequests) #6984

Closed
mattjohnsonpint opened this issue May 18, 2023 · 12 comments · Fixed by #6987
Closed

Document HTTP Client Errors (enableCaptureFailedRequests) #6984

mattjohnsonpint opened this issue May 18, 2023 · 12 comments · Fixed by #6987
Assignees

Comments

@mattjohnsonpint
Copy link
Contributor

Core or SDK?

Platform/SDK

Which part? Which one?

All SDKs

Description

In getsentry/team-mobile#38 - all SDKs added support for HTTP Client errors, per the developer docs here: https://develop.sentry.dev/sdk/features/#http-client-errors

However, only Apple has it documented:

All SDKs need to document this feature.

Suggested Solution

If the Apple specific doc page is made generic and converted to a common page, then each SDK team can modify the examples as appropriate for their platform.

@mattjohnsonpint
Copy link
Contributor Author

@jamescrosswell (contractor) recently completed this feature for .NET (see getsentry/sentry-dotnet#2320) and can take a first stab at this. (Thanks James!)

@marandaneto
Copy link
Contributor

marandaneto commented May 18, 2023

@jamescrosswell
Copy link
Collaborator

Docs on Contributing to Docs - meta but helpful ;-)

@mattjohnsonpint
Copy link
Contributor Author

Ok. So actually then, we should probably not generify the detail feature docs but rather just add new docs for .NET. @jamescrosswell - you can copy/past/modify the one from Apple to get started.

We do still need to make sure all platforms that expose enableCaptureFailedRequests on their main options class, have that option showing on the basic configuration page. We should also add a link from there to the detail page where appropriate.

@getsantry
Copy link
Contributor

getsantry bot commented May 18, 2023

Routing to @getsentry/product-owners-sdks-web-frontend for triage, due by Monday, May 22nd at 17:00 (vie). ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented May 18, 2023

Routing to @getsentry/product-owners-sdks-native for triage, due by Monday, May 22nd at 17:00 (vie). ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented May 18, 2023

Routing to @getsentry/product-owners-sdks-mobile for triage, due by Monday, May 22nd at 17:00 (vie). ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented May 18, 2023

Routing to @getsentry/product-owners-sdks-web-backend for triage, due by Monday, May 22nd at 17:00 (vie). ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented May 18, 2023

Routing to @getsentry/product-owners-sdks-web-frontend for triage, due by Monday, May 22nd at 17:00 (vie). ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented May 18, 2023

Routing to @getsentry/product-owners-sdks-web-backend for triage, due by Monday, May 22nd at 17:00 (vie). ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented May 18, 2023

Routing to @getsentry/product-owners-sdks-mobile for triage, due by Monday, May 22nd at 17:00 (vie). ⏲️

@hubertdeng123
Copy link
Member

hubertdeng123 commented May 22, 2023

The bot is going crazy since it only expects one Product Area label. Issues like this don't seem to happen very often and I don't think having multiple product areas per issue is an area we want to go in. Seems like for now it is assigned to an owner, sorry for the noise everyone

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants