Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RN): Improve documentation on React Native source maps #4452

Merged
merged 9 commits into from
Dec 1, 2021
Merged

feat(RN): Improve documentation on React Native source maps #4452

merged 9 commits into from
Dec 1, 2021

Conversation

jennmueng
Copy link
Member

@jennmueng jennmueng commented Nov 30, 2021 •
edited
Loading

  1. Hermes on iOS now requires the sourcemap compose step.
  2. Document how to differ bundles for different platforms via the dist: Fixes: CodePush version conflicts for set-commits sentry-react-native#533
  3. Link to troubleshooting section from the sourcemaps page
  4. Include dist in the old codepush example as not having a dist is no longer valid.

@jennmueng jennmueng requested a review from a team as a code owner November 30, 2021 21:46
@vercel
Copy link

vercel bot commented Nov 30, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/Ep76qnQqimfnGSGh9REJVTyrxwfy
✅ Preview: https://sentry-docs-git-fork-jennmueng-jenn-sourcemaps.sentry.dev

imatwawana
imatwawana approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor wording changes but otherwise LGTM!

src/platforms/react-native/sourcemaps.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/troubleshooting.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/troubleshooting.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/troubleshooting.mdx Outdated Show resolved Hide resolved
@marandaneto marandaneto merged commit be75875 into getsentry:master Dec 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@imatwawana imatwawana imatwawana approved these changes

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CodePush version conflicts for set-commits
3 participants
@jennmueng @marandaneto @imatwawana