Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodePush version conflicts for set-commits #533

Closed
dgobaud opened this issue Jan 25, 2019 · 6 comments · Fixed by getsentry/sentry-docs#4452
Closed

CodePush version conflicts for set-commits #533

dgobaud opened this issue Jan 25, 2019 · 6 comments · Fixed by getsentry/sentry-docs#4452
Labels
code-push uses microsoft code-push Platform: Docs Regarding the documentation 🦔react-native-sentry

Comments

@dgobaud
Copy link

dgobaud commented Jan 25, 2019

Following up on this #459

I have Android and iOS apps using CodePush in App Center.

From the above issue yes I see if eg Android is on v1 and iOS is on v2, later when Android gets up to v2 it will upload its artifacts to the existing v2 release which already has the iOS artifacts.

This is definitely a bit confusing/hard to browse in the release list since the original v2 release which is most current for Android could be buried behind a bunch of iOS only releases.

Now the bigger problem I think is what about associating commits? When iOS released I did releases set-commits auto.

Now Android is going to release to v2 and run releases set-commits auto again on the same release.

It seems you need to:

  1. Add the platform string into the release name

  2. Allow the release name to be specified in the react-native appcenter command.

@marandaneto marandaneto added the code-push uses microsoft code-push label Nov 4, 2021
@marandaneto
Copy link
Contributor

@jennmueng how do you usually do it?
looking at https://docs.sentry.io/platforms/react-native/manual-setup/codepush/
you can specify the platform + dist

@jennmueng
Copy link
Member

@marandaneto @dgobaud You should be able to specify the platform in the dist, will make a documentation note for it.

@dgobaud
Copy link
Author

dgobaud commented Nov 30, 2021

@jennmueng where or how exactly?

@jennmueng
Copy link
Member

@dgobaud

Sentry.init({
  ...
  dist: Platform.OS
})

and also set the dist when you upload the sourcemaps.

@dgobaud
Copy link
Author

dgobaud commented Nov 30, 2021

@jennmueng how do you do it with sourcemap upload? We are doing it with Sentry.init() maybe something was added to support sourcemap upload dist i don't think it did before?

@jennmueng
Copy link
Member

@dgobaud See the --dist in the sentry-cli react-native appcenter command here in the last code block: https://docs.sentry.io/platforms/react-native/manual-setup/codepush/#making-releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-push uses microsoft code-push Platform: Docs Regarding the documentation 🦔react-native-sentry
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants