-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Removing unused argument #4621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vaind I think this breaks session replay for Flutter. Can you take a look? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4621 +/- ##
=============================================
- Coverage 90.880% 90.874% -0.006%
=============================================
Files 617 617
Lines 71026 71024 -2
Branches 25313 25309 -4
=============================================
- Hits 64549 64543 -6
- Misses 6385 6387 +2
- Partials 92 94 +2
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ab0012c | 1209.06 ms | 1228.78 ms | 19.72 ms |
742d4b6 | 1204.00 ms | 1217.90 ms | 13.90 ms |
aad68bb | 1221.12 ms | 1237.41 ms | 16.29 ms |
de033da | 1206.55 ms | 1217.08 ms | 10.53 ms |
a2af9fa | 1236.62 ms | 1253.12 ms | 16.50 ms |
533859f | 1237.78 ms | 1249.76 ms | 11.98 ms |
965db8a | 1212.94 ms | 1233.41 ms | 20.47 ms |
d26c417 | 1235.02 ms | 1252.02 ms | 17.00 ms |
ee3f02e | 1236.53 ms | 1263.54 ms | 27.01 ms |
e324230 | 1244.43 ms | 1252.98 ms | 8.55 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ab0012c | 22.85 KiB | 415.09 KiB | 392.24 KiB |
742d4b6 | 21.58 KiB | 546.20 KiB | 524.61 KiB |
aad68bb | 21.58 KiB | 542.38 KiB | 520.80 KiB |
de033da | 21.58 KiB | 418.15 KiB | 396.57 KiB |
a2af9fa | 20.76 KiB | 432.87 KiB | 412.11 KiB |
533859f | 22.85 KiB | 408.84 KiB | 386.00 KiB |
965db8a | 22.84 KiB | 403.24 KiB | 380.39 KiB |
d26c417 | 21.58 KiB | 700.28 KiB | 678.70 KiB |
ee3f02e | 22.84 KiB | 401.67 KiB | 378.83 KiB |
e324230 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
SentryViewPhotographer had an unused argument for SentryViewPhotographer.image()
#skip-changelog