Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removing unused argument #4621

Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore: Removing unused argument #4621

merged 1 commit into from
Dec 11, 2024

Conversation

brustolin
Copy link
Contributor

SentryViewPhotographer had an unused argument for SentryViewPhotographer.image()

#skip-changelog

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin
Copy link
Contributor Author

@vaind I think this breaks session replay for Flutter. Can you take a look?

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.874%. Comparing base (506e809) to head (54521e5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4621       +/-   ##
=============================================
- Coverage   90.880%   90.874%   -0.006%     
=============================================
  Files          617       617               
  Lines        71026     71024        -2     
  Branches     25313     25309        -4     
=============================================
- Hits         64549     64543        -6     
- Misses        6385      6387        +2     
- Partials        92        94        +2     
Files with missing lines Coverage Δ
...tegrations/SessionReplay/SentrySessionReplay.swift 97.570% <100.000%> (ø)
Sources/Swift/Tools/SentryViewPhotographer.swift 93.750% <100.000%> (ø)
...tions/SessionReplay/SentrySessionReplayTests.swift 98.870% <100.000%> (ø)
...ests/SentryTests/SentryViewPhotographerTests.swift 99.635% <100.000%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506e809...54521e5. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.04 ms 1251.25 ms 16.21 ms
Size 22.31 KiB 756.42 KiB 734.12 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ab0012c 1209.06 ms 1228.78 ms 19.72 ms
742d4b6 1204.00 ms 1217.90 ms 13.90 ms
aad68bb 1221.12 ms 1237.41 ms 16.29 ms
de033da 1206.55 ms 1217.08 ms 10.53 ms
a2af9fa 1236.62 ms 1253.12 ms 16.50 ms
533859f 1237.78 ms 1249.76 ms 11.98 ms
965db8a 1212.94 ms 1233.41 ms 20.47 ms
d26c417 1235.02 ms 1252.02 ms 17.00 ms
ee3f02e 1236.53 ms 1263.54 ms 27.01 ms
e324230 1244.43 ms 1252.98 ms 8.55 ms

App size

Revision Plain With Sentry Diff
ab0012c 22.85 KiB 415.09 KiB 392.24 KiB
742d4b6 21.58 KiB 546.20 KiB 524.61 KiB
aad68bb 21.58 KiB 542.38 KiB 520.80 KiB
de033da 21.58 KiB 418.15 KiB 396.57 KiB
a2af9fa 20.76 KiB 432.87 KiB 412.11 KiB
533859f 22.85 KiB 408.84 KiB 386.00 KiB
965db8a 22.84 KiB 403.24 KiB 380.39 KiB
d26c417 21.58 KiB 700.28 KiB 678.70 KiB
ee3f02e 22.84 KiB 401.67 KiB 378.83 KiB
e324230 22.85 KiB 408.88 KiB 386.03 KiB

@brustolin brustolin merged commit fce741e into main Dec 11, 2024
64 of 66 checks passed
@brustolin brustolin deleted the chore/remove-unused-option branch December 11, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants