-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Remove default attachment content type #2443
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2ae7db9 | 1231.37 ms | 1239.98 ms | 8.61 ms |
c9129b6 | 1231.86 ms | 1270.11 ms | 38.25 ms |
68094b3 | 1214.14 ms | 1255.09 ms | 40.95 ms |
e2cec76 | 1189.48 ms | 1229.84 ms | 40.36 ms |
dcac8ad | 1238.82 ms | 1247.80 ms | 8.98 ms |
bbe81cb | 1257.25 ms | 1272.24 ms | 14.99 ms |
4dc66f6 | 1202.59 ms | 1228.34 ms | 25.75 ms |
7eee302 | 1228.73 ms | 1241.94 ms | 13.21 ms |
f91714d | 1222.06 ms | 1247.00 ms | 24.94 ms |
d10145a | 1232.65 ms | 1257.55 ms | 24.90 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2ae7db9 | 20.75 KiB | 381.87 KiB | 361.12 KiB |
c9129b6 | 20.75 KiB | 381.81 KiB | 361.06 KiB |
68094b3 | 20.75 KiB | 373.94 KiB | 353.19 KiB |
e2cec76 | 20.75 KiB | 381.81 KiB | 361.06 KiB |
dcac8ad | 20.75 KiB | 379.11 KiB | 358.36 KiB |
bbe81cb | 20.75 KiB | 381.81 KiB | 361.06 KiB |
4dc66f6 | 20.75 KiB | 381.81 KiB | 361.06 KiB |
7eee302 | 20.75 KiB | 374.73 KiB | 353.97 KiB |
f91714d | 20.75 KiB | 381.87 KiB | 361.12 KiB |
d10145a | 20.75 KiB | 379.12 KiB | 358.36 KiB |
Previous results on branch: ref/remove-default-attachment-type
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
89d24f2 | 1235.76 ms | 1246.86 ms | 11.10 ms |
b344897 | 1211.57 ms | 1232.76 ms | 21.19 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
89d24f2 | 20.75 KiB | 383.79 KiB | 363.03 KiB |
b344897 | 20.75 KiB | 383.82 KiB | 363.06 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When I search for |
Thanks @kevinrenskers |
📜 Description
Removed the default attachment content type.
This is defined at server side.
💡 Motivation and Context
close #1196
💚 How did you test it?
Unit tests
📝 Checklist
🔮 Next steps