Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default MIME content type for attachment #1196

Closed
philipphofmann opened this issue Jun 25, 2021 · 1 comment · Fixed by #2443
Closed

Remove default MIME content type for attachment #1196

philipphofmann opened this issue Jun 25, 2021 · 1 comment · Fixed by #2443
Assignees
@brustolin
Labels
Platform: Cocoa Type: Bug
Milestone
8.0.0

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Jun 25, 2021 •
edited by bruno-garcia
Loading

The SDK sets the default MIME content type to application/octet-stream, see

sentry-cocoa/Sources/Sentry/SentryAttachment.m

Line 6 in dd9501e

NSString *const DefaultContentType = @"application/octet-stream";

The content_type is optional for the envelope item attachment spec and the backend defaults to application/octet-stream anyways. Therefore we can remove setting the default on the client-side and let the backend set the default instead.
@philipphofmann philipphofmann added this to the 8.0.0 milestone Jun 25, 2021
@philipphofmann philipphofmann mentioned this issue Jun 25, 2021
Merged
5 tasks
@bruno-garcia bruno-garcia mentioned this issue Jul 7, 2021
Closed
@philipphofmann philipphofmann moved this to Needs Discussion in Mobile & Cross Platform SDK Dec 1, 2021
@philipphofmann philipphofmann moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Dec 15, 2021
@marandaneto marandaneto mentioned this issue Jan 18, 2022
Merged
4 tasks
@philipphofmann philipphofmann modified the milestones: 8.0.0, 9.0.0 Nov 16, 2022
@philipphofmann philipphofmann self-assigned this Nov 16, 2022
@brustolin brustolin mentioned this issue Nov 24, 2022
Merged
5 tasks
@brustolin
Copy link
Contributor

Solved by #2443

Repository owner moved this from Backlog to Done in Mobile & Cross Platform SDK Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brustolin brustolin

Labels
Platform: Cocoa Type: Bug
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

ref: Remove default attachment content type getsentry/sentry-cocoa
2 participants
@philipphofmann @brustolin