-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Report start up crashes #2220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipphofmann
force-pushed
the
feat/detect-start-up-crashes
branch
from
September 26, 2022 07:20
2f00a63
to
021d69c
Compare
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7138b7d | 1243.40 ms | 1252.08 ms | 8.68 ms |
864c39a | 1226.12 ms | 1248.26 ms | 22.13 ms |
202334c | 1265.41 ms | 1277.34 ms | 11.93 ms |
074350f | 1241.00 ms | 1249.60 ms | 8.60 ms |
4a66f00 | 1224.73 ms | 1241.14 ms | 16.41 ms |
864c39a | 1191.14 ms | 1233.38 ms | 42.24 ms |
172c95a | 1220.08 ms | 1251.74 ms | 31.66 ms |
9fc2dd0 | 1246.14 ms | 1275.00 ms | 28.86 ms |
791123d | 1256.10 ms | 1266.68 ms | 10.58 ms |
4a66f00 | 1259.84 ms | 1281.66 ms | 21.82 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7138b7d | 20.51 KiB | 331.79 KiB | 311.28 KiB |
864c39a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
202334c | 20.51 KiB | 331.79 KiB | 311.28 KiB |
074350f | 20.51 KiB | 335.52 KiB | 315.01 KiB |
4a66f00 | 20.51 KiB | 331.79 KiB | 311.28 KiB |
864c39a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
172c95a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
9fc2dd0 | 20.50 KiB | 331.79 KiB | 311.28 KiB |
791123d | 20.51 KiB | 331.81 KiB | 311.30 KiB |
4a66f00 | 20.51 KiB | 331.79 KiB | 311.28 KiB |
Previous results on branch: feat/detect-start-up-crashes
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5308b1e | 1236.73 ms | 1244.10 ms | 7.37 ms |
f03289c | 1227.66 ms | 1242.80 ms | 15.14 ms |
53ede48 | 1236.90 ms | 1255.30 ms | 18.40 ms |
03e9d9d | 1224.94 ms | 1238.77 ms | 13.83 ms |
88ce892 | 1229.32 ms | 1250.67 ms | 21.35 ms |
ab75e0c | 1223.40 ms | 1264.40 ms | 41.00 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5308b1e | 20.51 KiB | 332.54 KiB | 312.03 KiB |
f03289c | 20.51 KiB | 332.59 KiB | 312.08 KiB |
53ede48 | 20.51 KiB | 332.48 KiB | 311.98 KiB |
03e9d9d | 20.51 KiB | 335.69 KiB | 315.19 KiB |
88ce892 | 20.51 KiB | 332.47 KiB | 311.96 KiB |
ab75e0c | 20.51 KiB | 335.69 KiB | 315.18 KiB |
brustolin
reviewed
Sep 26, 2022
Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_AppState.c
Outdated
Show resolved
Hide resolved
philipphofmann
changed the base branch from
master
to
test/remove-empty-assertions
September 26, 2022 07:54
philipphofmann
changed the title
feat: Report app launch crashes
feat: Report start up crashes
Sep 26, 2022
philipphofmann
requested review from
armcknight and
indragiek
as code owners
September 27, 2022 10:35
brustolin
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
If the app crashes after 2 seconds of the SDK init, the SDK makes the SDK init call blocking
by calling flush with 5 seconds.
💡 Motivation and Context
Fixes GH-316 also tracked in getsentry/team-mobile#12.
💚 How did you test it?
Unit tests, and real devices.
📝 Checklist
🔮 Next steps