Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to make start up crash reporting non-blocking #3044

Closed
ghost opened this issue May 19, 2023 · 2 comments
Closed

Option to make start up crash reporting non-blocking #3044

ghost opened this issue May 19, 2023 · 2 comments

Comments

@ghost
Copy link

ghost commented May 19, 2023

Problem Statement

#2220 introduced a feature to report crashes on the main thread if they were considered to be start up crashes. This in turn causes beforeSend of Sentry.Options to run on the main thread as well.

Our implementation requires user interaction before sending any crash reports which is currently implemented by blocking the thread beforeSend is running on. This doesn't work if it is running on the main thread.

Solution Brainstorm

An option to make start up crash reporting non-blocking / best effort would solve our issue.

Are you willing to submit a PR?

We'd be happy to submit a PR

@philipphofmann
Copy link
Member

The purpose of start-up crashes is that the SDK init waits synchronously for up to 5 seconds to flush out events if the app crashes within 2 seconds after the SDK init to ensure sending a crash report before your app crashes again. Making it asynchronous doesn't make any sense for this feature, as it's basically disabling it. Anyways, maybe you could find a workaround by grabbing the event from beforeSend and return nil, so it doesn't get sent, store it in memory and once you get the confirmation, call captureEvent, which is basically disabling the feature with a workaround. Another idea would be to add an option to disable this feature. What would work for you, @threema-jarem?

@brustolin brustolin moved this from Needs Discussion to Needs More Information in Mobile & Cross Platform SDK May 24, 2023
@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2023
@github-project-automation github-project-automation bot moved this from Needs More Information to Done in Mobile & Cross Platform SDK Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant