fix: Solve the "Double-quoted include" warnings

[kevinrenskers]

📜 Description

Fixes all the "Double-quoted include" warnings. You could easily trigger them by building the ObjC sample app.

💡 Motivation and Context

Closes #1072

💚 How did you test it?

Compiling the app and the sample apps still works, all the tests still work.

📝 Checklist

• I reviewed the submitted code
• I added tests to verify the changes
• I updated the docs if needed
• Review from the native team if needed
• No breaking changes

🔮 Next steps

[kevinrenskers]

Integration tests fail on #import <Sentry/SentryDefines.h>. Not sure why, as locally it all works, also when building the sample apps. @brustolin any ideas?

[brustolin]

Integration tests fail on #import <Sentry/SentryDefines.h>. Not sure why, as locally it all works, also when building the sample apps. @brustolin any ideas?

Nope. I tried to do this too some time ago and SPM is not happy. And SPM is a must for us.

[kevinrenskers]

Unless someone else has some insight into this I guess we close this and live with the warnings? But surely other SDKs don't generate the same kind of warnings so this should be possible to solve I would think.

[armcknight]

If we're adding the Sentry SDK directly to one of the AlamoFire example projects, you could try integrating it via CocoaPods/Carthage/SPM instead, both to see if the resultant changes still match what is in our patchfile, and to see if it passes in CI also/anyways.

Our current approach of applying a patch file is more brittle than that so seems like it'd also leave things in a better state if we did that moving forwards.

[kevinrenskers]

I've looked at integration-tests.yml and add-sentry-to-alamofire.patch, and I have a suspicion that it's already integrated with SPM? Since there's mention of a XCRemoteSwiftPackageReference with the URL https://github.com/getsentry/sentry-cocoa.. so I don't think we're adding the Sentry SDK directly as you said?

+/* Begin XCRemoteSwiftPackageReference section */
+		7B4C98B32743C1FE00B03EC9 /* XCRemoteSwiftPackageReference "sentry-cocoa" */ = {
+			isa = XCRemoteSwiftPackageReference;
+			repositoryURL = "https://github.com/getsentry/sentry-cocoa";
+			requirement = {
+				kind = revision;
+				revision = __GITHUB_REVISION_PLACEHOLDER__;
+			};
+		};
+/* End XCRemoteSwiftPackageReference section */
+
+/* Begin XCSwiftPackageProductDependency section */
+		7B4C98B42743C1FE00B03EC9 /* Sentry */ = {
+			isa = XCSwiftPackageProductDependency;
+			package = 7B4C98B32743C1FE00B03EC9 /* XCRemoteSwiftPackageReference "sentry-cocoa" */;
+			productName = Sentry;
+		};
+/* End XCSwiftPackageProductDependency section */

This looks similar to me as a test project I created and added sentry-cocoa via SPM.

[brustolin]

and I have a suspicion that it's already integrated with SPM?

Yes. The problem is not the integration, the problem is the way SPM is build.
All you need to do is make sure swift build works which based on this action Build / Build with Swift (pull_request) is not.
I really think this worth an extra investigation, it would be nice to have this solved, but if this is taking too long we close the PR, this is definitely not a high priority.

[armcknight]

Hm, it sounds like we might need something like #1726 first. If SPM links Sentry statically, then framework-style imports probably won't work.

[brustolin]

Hm, it sounds like we might need something like #1726 first. If SPM links Sentry statically, then framework-style imports probably won't work.

But even then this won't work, I think, because the static lib options will still be available

[github-actions]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[philipphofmann]

#1726 was merged, @kevinrenskers can you please revisit this PR?

[kevinrenskers]

Will do

[kevinrenskers]

We're still getting fatal errors like fatal error: 'Sentry/SentryDefines.h' file not found.

Anyone got an idea on how to fix this? I'm really not experienced with frameworks and static/dynamic libs and how that works with SPM etc etc.

But @brustolin did predict this:

But even then this won't work, I think, because the static lib options will still be available

So not sure if anything can be done.

[philipphofmann]

I also don't know how to fix this right now, and sadly I don't have the bandwidth to look at this. We can also close this PR, if we can't figure it out right now.