Provide fallbacks for assertions in production #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #2109 #skip-changelog
kevinrenskers
requested review from
philipphofmann,
brustolin,
armcknight and
indragiek
as code owners
kevinrenskers
commented
Sep 12, 2022
kevinrenskers
commented
Sep 12, 2022
Sources/Sentry/SentrySwizzle.m
Outdated
| @@ -20,6 +20,9 @@ @implementation SentrySwizzleInfo | |||
| - (SentrySwizzleOriginalIMP)getOriginalImplementation | |||
| { | |||
| NSAssert(_impProviderBlock, nil); | |||
There was a problem hiding this comment.
@armcknight mentioned the redundant nil here, but if I remove it the code no longer compiles 🤔
Too few arguments provided to function-like macro invocation
So I guess the nil was added with good reason. Or we could give it a proper string instead?
There was a problem hiding this comment.
We should add a message, otherwise we get an assertion/exception with an empty message
There was a problem hiding this comment.
Typically in the past I've wrapped this in a macro like SENTRY_ASSERT_NONNULL
There was a problem hiding this comment.
I added a message
Performance metrics 🚀
|
armcknight
approved these changes
Sep 12, 2022
kevinrenskers
added a commit
that referenced
this pull request
Sep 15, 2022
* master: (73 commits) ref: Fix typo in measurement (#2154) Fix typos in changelog (#2153) docs: Add a note on flaky tests to Contributing (#2161) docs: fix PR reference in CHANGELOG (#2157) test: generate graphs for benchmarks (#2158) release: 7.25.1 fix: Prewarmed app start detection (#2151) ci: temporarily disable scheduled CI runs uploading profiles/symbols (#2152) Run tests on iOS 16 using Xcode 14.0 (#2147) ref: Fix Xcode 14 compile issues (#2145) Provide fallbacks for assertions in production (#2141) Fix compile errors in Xcode 14 (#2146) release: 7.25.0 fix: setting SDK name through options[sdk][name] shouldn't clear version (#2139) fix: SentryTracer instances should be called "tracer", not "transaction" (#2137) ref: functions to convert to/from enum cases (#2108) fix: Crash with screenshot is reported twice (#2134) meta: Clarify PR rules in Contributing (#2133) meta: Fix Changelog (#2136) feat: Add support for dynamic library (#1726) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide fallbacks for assertions in production.
Closes #2109
#skip-changelog