Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentry error reporting to install.sh #740

Closed
BYK opened this issue Nov 17, 2020 · 5 comments · Fixed by #1679
Closed

Add Sentry error reporting to install.sh #740

BYK opened this issue Nov 17, 2020 · 5 comments · Fixed by #1679

Comments

@BYK
Copy link
Member

BYK commented Nov 17, 2020

Summary

sentry-cli has a Docker image and Bash signal trap support: https://docs.sentry.io/product/cli/send-event/#bash-hook

The two didn't play well together but now this can be overcome: getsentry/sentry-cli#852

Hence, we should try this out and see if it is useful to catch unknown issues in the wild.

Motivation

We rely on people to report issues with the install script and provide relevant logs along with that. This has worked okay so far but the process is very manual, cumbersome, and relies on the users reporting issues. Sentry was created to solve these issues to why not dog food?

@github-actions
Copy link

github-actions bot commented Jan 4, 2021

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Accepted, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Accepted, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@chadwhitacre
Copy link
Member

@armenzg has a blog post coming out about how the Developer Productivity team did something very similar with our environment bootstrapping script. Inspo!

emmatyping added a commit that referenced this issue Sep 13, 2022
This is the MVP of error monitoring of the self-hosted installer. We have:
- Added a prompt for users to opt into error reporting
- Rewritten the traceback code to give a full stack trace
- Hooked up sending errors to our self-hosted instance

Fixes #740

Co-authored-by: Chad Whitacre <[email protected]>
Co-authored-by: hubertdeng123 <[email protected]>
@chadwhitacre
Copy link
Member

I'm going to reopen this because there are many more details we need to pay attention to in order to not piss off users with this change.

@chadwhitacre chadwhitacre reopened this Sep 14, 2022
@chadwhitacre
Copy link
Member

Sorry ... we've got getsentry/team-ospo#36 as our meta ticket.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants