feat(profiling): Add a profile data category and count profiles in an envelope to apply rate limits #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phacops
changed the title
jan-auer
requested changes
May 4, 2022
| @@ -103,7 +103,7 @@ fn infer_event_category(item: &Item) -> Option<DataCategory> { | |||
| ItemType::MetricBuckets => None, | |||
| ItemType::FormData => None, | |||
| ItemType::UserReport => None, | |||
| ItemType::Profile => None, | |||
| ItemType::Profile => Some(DataCategory::Profile), | |||
There was a problem hiding this comment.
Profiles aren't events, so infer_event_category should not return something here.
|
Final ask, when you patch up the changelog, could you please also drop the same line in |
…ory as profile is not an event
phacops
force-pushed
the
pierre/profiling-data-category
branch
from
ea63f1b to
64b4469
Compare
jan-auer
added a commit
that referenced
this pull request
May 13, 2022
* master: feat(sampling): Support custom tags and more contexts (#1268) deps: Update symbolic to pull in Unreal parser fixes (#1266) Bring in CLA Lite (#1257) release: 0.8.11 ref(profiling): Normalize all profiles (#1250) feat(profiling): Add a profile data category and count profiles in an envelope to apply rate limits (#1259) fix: Raise a new InvalidCompression Outcome for invalid Unreal compression (#1237) chore: Update logo for dark or light theme (#1262) ref: Use Duration to compute breakdowns and span durations (#1260)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add the necessary code to count and apply rate limits to profiles. Right now, we don't want to apply any as we're in beta but we'd like to be ready for when we'd want to rate limit.
Ref #1258