fix: Raise a new InvalidCompression Outcome for invalid Unreal compression [ISSUE-1454] #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've mentioned that you'd like to specifically detect invalid encoding. I agree that it makes sense to introduce a new outcome for this, and detect invalid content encoding when converting from |
|
I think this change here is fair to do. I was rather questioning why |
Swatinem
force-pushed
the
fix/unreal-compression
branch
from
f4c1a90 to
db8f2be
Compare
Swatinem
changed the title
jan-auer
approved these changes
May 6, 2022
jan-auer
changed the title
Fun fact, the docstring describes that as |
jan-auer
added a commit
that referenced
this pull request
May 13, 2022
* master: feat(sampling): Support custom tags and more contexts (#1268) deps: Update symbolic to pull in Unreal parser fixes (#1266) Bring in CLA Lite (#1257) release: 0.8.11 ref(profiling): Normalize all profiles (#1250) feat(profiling): Add a profile data category and count profiles in an envelope to apply rate limits (#1259) fix: Raise a new InvalidCompression Outcome for invalid Unreal compression (#1237) chore: Update logo for dark or light theme (#1262) ref: Use Duration to compute breakdowns and span durations (#1260)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure this is the right thing to do, however as much as I can tell ISSUE-1454 looks like the Unreal reporter is sending invalid compression payloads. Might be good to distinguish those from actual Unreal parse errors.