Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix product owner mentions #439

Merged
merged 2 commits into from
May 1, 2023
Merged

Fix product owner mentions #439

merged 2 commits into from
May 1, 2023

Conversation

chadwhitacre
Copy link
Member

@chadwhitacre chadwhitacre commented May 1, 2023 •
edited
Loading

  • removes label description hack (since we have better control of both sides now)
  • standardize on product-owners- prefix
  • match slugification algorithm to security-as-code

@chadwhitacre chadwhitacre force-pushed the cwlw/fix-product-owner-mentions branch 2 times, most recently from b75d5b1 to 62045af Compare May 1, 2023 16:50
@chadwhitacre chadwhitacre marked this pull request as ready for review May 1, 2023 16:51
@chadwhitacre chadwhitacre mentioned this pull request May 1, 2023
Closed
@chadwhitacre chadwhitacre force-pushed the cwlw/fix-product-owner-mentions branch from 62045af to bfe6543 Compare May 1, 2023 16:54
@chadwhitacre chadwhitacre requested a review from hubertdeng123 May 1, 2023 16:54
hubertdeng123
hubertdeng123 approved these changes May 1, 2023
View reviewed changes
src/api/github/__mocks__/getClient.ts Show resolved Hide resolved
src/utils/slugizeProductArea.ts Show resolved Hide resolved
@chadwhitacre chadwhitacre merged commit fe9a82b into main May 1, 2023
@chadwhitacre chadwhitacre deleted the cwlw/fix-product-owner-mentions branch May 1, 2023 17:13
This was referenced May 1, 2023
Closed
Merged
@chadwhitacre chadwhitacre mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BYK BYK BYK left review comments

@hubertdeng123 hubertdeng123 hubertdeng123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chadwhitacre @BYK @hubertdeng123