refreshing snowflake schema w/o waking cluster #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Oct 24, 2019
redash/query_runner/snowflake.py
Outdated
| @@ -104,16 +104,47 @@ def run_query(self, query, user): | |||
|
|
|||
| return json_data, error | |||
|
|
|||
| def __run_query_without_warehouse(self, query, user): | |||
There was a problem hiding this comment.
Suggested change
| def __run_query_without_warehouse(self, query, user): | |
| def _run_query_without_warehouse(self, query): |
A single underscore is enough :) (need to update the function call below too).
Also no need to take a user object here.
|
@arikfr addressed PR comments and rebased from master |
added 3 commits
October 28, 2019 20:17
Have also added a new internal method to not select a warehouse while executing query Using 'show columns' to fetch database schema instead of executing a select query in information schema show columns does not require a warehouse to run
fixing internal function syntax and avoiding code repetition
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Refreshing snowflake schema w/o waking cluster. Used
show columnsfor this which executes the command w/o having to require a warehouse.Created a new internal function in the query runner
__run_query_without_warehouseinstead of modifying the existingrun_queryfunction so as to not change the definition as specified in the base classRelated Tickets & Documents
#4217