-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SHOW_COLUMNS to fetch Snowflake's schema #4217
Comments
@arikfr are there any tests for snowflake with which any change to snowflake query runner can be verified ? |
@monicagangwar this is a great question. Sadly, the answer is no :-( Most of the query runners are untested. It's something we do want to address (see #3807), but will take us time to get there. |
@arikfr alright. Although i've seen there is no pagination handled while refreshing schema.
Should I handle this in the PR ? |
@monicagangwar let's ignore the 10K limit for now. If we get reports of this being an issue will try to think of how to address it. Thanks! |
@arikfr - Can this issue be closed? I was looking for some low hanging fruit I could help out with, but it seems the update was already merged. |
@bradleyhurley definitely. Thanks for noticing! |
Issue Summary
The current method of refreshing the Snowflake schema is starting a cluster, which is undesired -- specially when doing a background refresh of the schema.
We can alternatively use
SHOW_COLUMNS
to load the schema without waking a up a cluster.Technical details:
The text was updated successfully, but these errors were encountered: