Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SHOW_COLUMNS to fetch Snowflake's schema #4217

Closed
arikfr opened this issue Oct 6, 2019 · 6 comments
Closed

Use SHOW_COLUMNS to fetch Snowflake's schema #4217

arikfr opened this issue Oct 6, 2019 · 6 comments
Labels
Backend hacktoberfest Hacktoberfest Friendly Issues help wanted

Comments

@arikfr
Copy link
Member

arikfr commented Oct 6, 2019

Issue Summary

The current method of refreshing the Snowflake schema is starting a cluster, which is undesired -- specially when doing a background refresh of the schema.

We can alternatively use SHOW_COLUMNS to load the schema without waking a up a cluster.

Technical details:

  • Redash Version: v8
@monicagangwar
Copy link
Contributor

@arikfr are there any tests for snowflake with which any change to snowflake query runner can be verified ?

@arikfr
Copy link
Member Author

arikfr commented Oct 24, 2019

@monicagangwar this is a great question. Sadly, the answer is no :-( Most of the query runners are untested. It's something we do want to address (see #3807), but will take us time to get there.

@monicagangwar
Copy link
Contributor

@arikfr alright. Although i've seen there is no pagination handled while refreshing schema.
A/c to the documentation for SHOW COLUMNS

The command returns a maximum of 10K records for the specified object type, as dictated by the access privileges for the role used to execute the command; any records above the 10K limit are not returned, even with a filter applied.

Should I handle this in the PR ?

@arikfr
Copy link
Member Author

arikfr commented Oct 24, 2019

@monicagangwar let's ignore the 10K limit for now. If we get reports of this being an issue will try to think of how to address it.

Thanks!

@bradleyhurley
Copy link

@arikfr - Can this issue be closed? I was looking for some low hanging fruit I could help out with, but it seems the update was already merged.

@arikfr
Copy link
Member Author

arikfr commented Jan 28, 2020

@bradleyhurley definitely. Thanks for noticing!

@arikfr arikfr closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend hacktoberfest Hacktoberfest Friendly Issues help wanted
Projects
None yet
Development

No branches or pull requests

3 participants