Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback icon adjustment for tall components #3974

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Feedback icon adjustment for tall components #3974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ded6ae
Revert "Add feedbackIcon"
ranbena Jul 12, 2019
8613675
Adjusted feedback icon
ranbena Jul 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions client/app/assets/less/ant.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,3 +345,22 @@
}
}
}

// overrides for tall form components such as ace editor
.@{form-prefix-cls}-item {
&-children {
display: block; // so feeback icon positions correctly
}

// no change for short components, sticks to body for tall ones
&-children-icon {
top: auto !important;
bottom: 8px;

// makes the icon white instead of see-through
& svg {
background: white;
border-radius: 50%;
}
}
}
2 changes: 0 additions & 2 deletions client/app/components/AceEditorInput.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import React, { forwardRef } from 'react';
import AceEditor from 'react-ace';

import './AceEditorInput.less';

function AceEditorInput(props, ref) {
return (
<div className="ace-editor-input">
Expand Down
12 changes: 0 additions & 12 deletions client/app/components/AceEditorInput.less
View file
Open in desktop

This file was deleted.