Feedback icon adjustment for tall components #3974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cc0a53b.
ranbena
changed the title
1 task
gabrieldutra
approved these changes
Jul 12, 2019
|
The Hide cursor thing was in that commit 😅. I'll put it back after merge, one last thing, the Scrollbar issue (images below) seems to happen due to a Before After |
Oh man. So glad there's someone sharper than me in the team 🤦♂️
Hmmm the result does not look appealing. I tried a few alternatives but nothing wins over it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A generic implementation for feedback icon positioning.
Reverted the original fix.