Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: organization setting for time format #3754

Merged
merged 3 commits into from
May 5, 2019
Merged

Add: organization setting for time format #3754

merged 3 commits into from
May 5, 2019

Conversation

yusukegoto
Copy link
Contributor

@yusukegoto yusukegoto commented May 2, 2019 •
edited by kravets-levko
Loading

What type of PR is this? (check all applicable)

  • Feature

Description

Add small patch of time format. I left timezone support for some complex reasons.

Related Tickets & Documents

#618

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Settings

screen

Query

query

@rauchy
Copy link
Contributor

rauchy commented May 2, 2019

Thanks! LGTM 👍

rauchy
rauchy approved these changes May 2, 2019
View reviewed changes
redash/handlers/authentication.py Outdated Show resolved Hide resolved
@arikfr
Copy link
Member

arikfr commented May 2, 2019

Can you please trigger a new build?

@yusukegoto yusukegoto closed this May 2, 2019
@yusukegoto yusukegoto reopened this May 2, 2019
@yusukegoto
Copy link
Contributor Author

yusukegoto commented May 2, 2019 •
edited
Loading

@arikfr
Could you help me? How can I build with PERCY_TOKEN s in Spin up Environment.
Pushing commits to my repo seems useless.
https://circleci.com/gh/yusukegoto/redash/41?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@gabrieldutra
Copy link
Member

Hi @yusukegoto 🙂

Do you have CircleCI configured for your redash's fork? If so, I think it doesn't trigger in our side 😕 (therefore it doesn't get our token).

@yusukegoto
Copy link
Contributor Author

Unit tests has passed! I created my own circleci settings for forked repo.

@yusukegoto
Copy link
Contributor Author

Please review percy diff 🙇

@arikfr arikfr changed the title Time format Add: organization setting for time format May 5, 2019
@arikfr arikfr merged commit 2cd1b07 into getredash:master May 5, 2019
@arikfr
Copy link
Member

arikfr commented May 5, 2019

Thanks, @yusukegoto !

@gabrieldutra note that you will need to rebase this into your organization settings PR.

@gabrieldutra gabrieldutra mentioned this pull request May 6, 2019
Merged
3 tasks
@weekly-digest weekly-digest bot mentioned this pull request May 6, 2019
Closed
@yusukegoto yusukegoto deleted the time-format branch May 28, 2019 23:37
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
@yusukegoto @harveyrendell
Add: organization setting for time format (getredash#3754)
4abe6cd 
* Support for time format

* Add selects test

* Rename into date_time_format_config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauchy rauchy rauchy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yusukegoto @rauchy @arikfr @gabrieldutra