Migrate Organization Settings to React #3728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldutra
commented
Apr 20, 2019
There was a problem hiding this comment.
@arikfr, @ranbena so far this is migrated (almost) as is, before moving forward I have some ideas to the page so we can decide what can be applied here:
- Add a sidebar separating "General" and "Authentication" settings
- Add a HelpTrigger to Authentication (I think there'll be no discussion on this one, it's just so I don't forget to add it :) )
- Make "SAML Enabled" check modify SAML disabled state instead of making inputs appear/disappear (better if we separate with a sidebar)
- Improvements for Feature Flags, they seem to be an interesting way for us to add features faster and for A/B testing. It'd be good to have explanations to what each feature affect and perhaps it's own Sidebar tab?
| @border-color-base: #E8E8E8; | ||
| @form-item-margin-bottom: 15px; |
There was a problem hiding this comment.
Default: 24px which I think is too much(?)
I usually replace this value for each Form I create. If I'm not the only one with this issue I'll separate this into another PR so I can handle all existing forms properly.
|
Let's add the help trigger but leave everything as is.
…On Sun, Apr 21, 2019, 01:22 Gabriel Dutra ***@***.***> wrote:
***@***.**** commented on this pull request.
@arikfr <https://github.com/arikfr>, @ranbena <https://github.com/ranbena>
so far this is migrated (almost) as is, before moving forward I have some
ideas to the page so we can decide what can be applied here:
- Add a sidebar separating "General" and "Authentication" settings
- Add a HelpTrigger to Authentication
<https://redash.io/help/user-guide/users/authentication-options> (I
think there'll be no discussion on this one, it's just so I don't forget to
add it :) )
- Make "SAML Enabled" check modify SAML disabled state instead of
making inputs appear/disappear (better if we separate with a sidebar)
- Improvements for Feature Flags, they seem to be an interesting way
for us to add features faster and for A/B testing. It'd be good to have
explanations to what each feature affect and perhaps it's own Sidebar tab?
------------------------------
In client/app/assets/less/inc/ant-variables.less
<#3728 (comment)>:
> @border-color-base: #E8E8E8;
***@***.***: 15px;
Default: 24px which I think is too much(?)
I usually replace this value for each Form I create. If I'm not the only
one with this issue I'll separate this into another PR so I can handle all
existing forms properly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3728 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAROLH2VT3NGSL4VN7HWVDPROJQLANCNFSM4HHKPSOQ>
.
|
|
Updated with #3754 :) |
gabrieldutra
added
Frontend
Frontend: React
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* Migrate Organization Settings to React * Fix failing spec and replace default values from inputs * Add HelpTrigger and handleChange to SAML options * Undo changes to ant-variables.less * Add time format to OrganizationSettings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Migration for the Organization Settings Page, so far migrated (almost) as is.
Differences:
DraftRelated Tickets & Documents
--
Mobile & Desktop Screenshots/Recordings (if there are UI changes)