Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make actions column fixed #3541

Closed
wants to merge 2 commits into from
Closed

Make actions column fixed #3541

wants to merge 2 commits into from

Conversation

kravets-levko
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix

Description

Possible fix for #3521: make columns with action buttons fixed (see screenshots).

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

image

image

@ghost ghost assigned ranbena Mar 7, 2019
@ranbena
Copy link
Contributor

ranbena commented Mar 7, 2019

@kravets-levko Even-though #3545, this PR could function as a fail-safe in case sth gets messed up. Wdyt?

@gabrieldutra
Copy link
Member

@kravets-levko Even-though #3545, this PR could function as a fail-safe in case sth gets messed up. Wdyt?

This is currently being applied to mobiles, even though #3545:
mobile-users

@kravets-levko
Copy link
Collaborator Author

@gabrieldutra because, as I mentioned, fixing group labels is not enough - on narrow screens there will be scroll anyway.

@kravets-levko
Copy link
Collaborator Author

@ranbena

Even-though #3545, this PR could function as a fail-safe in case sth gets messed up. Wdyt?

While it fixes the bug perfectly, design-wise it's unappealing. 😁

@ranbena
Copy link
Contributor

ranbena commented Mar 7, 2019

Mobile needs a different and dedicated layout. Currently, mobile doesn't work with or without the fixed col.
IMO, if it can be easily turned off for mobile - let's use it, if not - let's withdraw the idea.

@kravets-levko
Copy link
Collaborator Author

While this fix was one of possible options, I don't like it that much. Therefore I decided to close this PR. We should find a better solution for lists on small screens.

@ghost ghost removed the in progress label Mar 7, 2019
@kravets-levko kravets-levko deleted the fix/list-pages-table-scroll branch March 10, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants